rbac: operators should not contain permissions to create CRD #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is required for the OLM part. If we allow creating CRDs, then validation of the operator will fail for the OLM workflow. As such, I'm removing the permission of creating the CRD and will leave it to the OLM during the packaging process (next PR). |
Collaborator
Author
|
Adding the NRT CRD under |
According to the best practices of OLM, operators should not contain permissions to create CRD. It's the Operator Lifecycle Manager's job to manage the deployment and lifecycle of operators and CRDs. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
fmuyassarov
force-pushed
the
prepare-rbac
branch
from
f8f7f51 to
67d1092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the best practices of OLM, operators should not contain permissions to create CRD. It's the Operator Lifecycle Manager's job to manage the deployment and lifecycle of operators and CRDs.