-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change the order of elements on the dashboard page #8381
chore: change the order of elements on the dashboard page #8381
Conversation
Looking great !! |
Please see #8339 (comment) I don't think this is a good change at the moment. The on-boarding / learning center / recommended is so large I now have to scroll to the bottom to find what I immediately want to see when first starting podman desktop, and that's seeing if any of my providers need setup / have problems / etc. |
@cdrage : We'll proceed with little steps, but the intent is to move the providers into the status bar. While this PR might make the experience for interacting with the provider a bit harder - there are still other places where the users are interacting with providers. Unfortunately, this place is also the only place where we can drive more awareness on the featured extension and expose AI Lab a bit more. |
Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>
9ee563d
to
dedb370
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very impactful change, not sure if it should be merged before 1.13 like this cc @benoitf @deboer-tim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
However I disagree with the design choice and I feel like this may be better changed in a future PR with regards to the complete dashboard revamp.
Approving based solely on code changed!
I also agree with @axel7083 that maybe change should be done post 1.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge, we have other enhancements that will come (ability to hide, remove ext-pack) so we can try it anyway and still revert before cutting the release if the order is still not a good thing
What does this PR do?
Temporary changes the order of elements on the dashboard page
Screenshot / video of UI
What issues does this PR fix or reference?
Closes #8339
How to test this PR?