Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change the order of elements on the dashboard page #8381

Conversation

gastoner
Copy link
Contributor

@gastoner gastoner commented Aug 8, 2024

What does this PR do?

Temporary changes the order of elements on the dashboard page

Screenshot / video of UI

image

What issues does this PR fix or reference?

Closes #8339

How to test this PR?

  • Tests are covering the bug fix or the new feature

@gastoner gastoner requested review from benoitf and a team as code owners August 8, 2024 07:46
@gastoner gastoner requested review from dgolovin, lstocchi and SoniaSandler and removed request for a team August 8, 2024 07:46
@gastoner gastoner self-assigned this Aug 8, 2024
@gastoner gastoner requested a review from slemeur August 8, 2024 07:57
@slemeur
Copy link
Contributor

slemeur commented Aug 8, 2024

Looking great !!

@cdrage
Copy link
Contributor

cdrage commented Aug 8, 2024

Please see #8339 (comment)

I don't think this is a good change at the moment.

The on-boarding / learning center / recommended is so large I now have to scroll to the bottom to find what I immediately want to see when first starting podman desktop, and that's seeing if any of my providers need setup / have problems / etc.

@slemeur
Copy link
Contributor

slemeur commented Sep 12, 2024

@cdrage : We'll proceed with little steps, but the intent is to move the providers into the status bar.
Please keep in mind that we have 3 ways at the moment to access the providers: Settings, Dashboard, Tray Menu.

While this PR might make the experience for interacting with the provider a bit harder - there are still other places where the users are interacting with providers.

Unfortunately, this place is also the only place where we can drive more awareness on the featured extension and expose AI Lab a bit more.

@slemeur
Copy link
Contributor

slemeur commented Sep 12, 2024

@gastoner : you might want to recheck this PR with #8339 (where the requirements changed a bit) and also check with the work here: #8753

Signed-off-by: Evzen Gasta <evzen.ml@seznam.cz>
@gastoner gastoner force-pushed the change_the_order_of_elements_on_the_dashboard_page branch from 9ee563d to dedb370 Compare October 7, 2024 05:36
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very impactful change, not sure if it should be merged before 1.13 like this cc @benoitf @deboer-tim

Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

However I disagree with the design choice and I feel like this may be better changed in a future PR with regards to the complete dashboard revamp.

Approving based solely on code changed!

I also agree with @axel7083 that maybe change should be done post 1.13

@axel7083 axel7083 dismissed their stale review October 17, 2024 17:09

1.13 has been release

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge, we have other enhancements that will come (ability to hide, remove ext-pack) so we can try it anyway and still revert before cutting the release if the order is still not a good thing

@gastoner gastoner merged commit 99c099a into podman-desktop:main Oct 21, 2024
15 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.14.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the order of elements on the dashboard page
8 participants