refactor: move api sender type to api package #8748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
requested review from
jeffmaury,
feloy and
deboer-tim
and removed request for
a team
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
|
As requested setting to draft and wait for further discussion/planning |
|
Too much conflict closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
ApiSenderTypeis used in a lot of places (renderer, preload etc.), which import it directly from themainpackage, leading to long imports. This PR move theIDiposablethat ApiSenderType extends, and the ApiSenderType interface itself to the api package.Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Related to #8746
How to test this PR?