-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add new stories for UI components #8836
Conversation
7393f98
to
58a6afa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I'm testing by running
pnpm dev
from thestorybook
directory, I'm not sure if there is a better way -
In the Docs page, the Stories are not displaying anything (they are displayed correctly in dedicated pages):
- In the source code,
<wrapper
is displayed instead of the real component name.
- could the terminal displaying the code be in light mode?
@feloy I think the best way is to render the final look or go to the website (click on the netlify link of this PR) https://66e1a382d9435a070cc59d87--podman-desktop-pr.netlify.app/storybook/ |
ok, thanks. So the only remaining concern would be:
|
there might be a way but it's not related to this PR that only bring new stories (no terminal being added) you can create the issue, it'll be for the storybook/docusaurus integration |
58a6afa
to
ea2b7f6
Compare
I've added a bunch of argsTypes parameters + example on selected for the tab also added an extra padding on tooltip to see the tooltip |
ea2b7f6
to
d711492
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the changes
fixes podman-desktop#7441 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
d711492
to
6a783ea
Compare
@dgolovin I fixed the dropdown rendering by adding a min-height and a padding I renamed also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
What does this PR do?
Add new stories for UI components
Screenshot / video of UI
https://66f17e753e2f921f3f94916e--podman-desktop-pr.netlify.app/storybook
What issues does this PR fix or reference?
fixes #7441
How to test this PR?