Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): added documentation for managing docker compatibility #8898

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented Sep 16, 2024

Signed-off-by: Shipra Singh shipsing@redhat.com

What does this PR do?

Add documentation about managing docker compatibility from the Settings area

The procedural content might change based on the work that is being done here: #8338.

Screenshot / video of UI

PR preview: https://66fb961359784ac56507d4fd--podman-desktop-pr.netlify.app/docs/migrating-from-docker/managing-docker-compatibility

What issues does this PR fix or reference?

#8636

How to test this PR?

  • Tests are covering the bug fix or the new feature

Signed-off-by: Shipra Singh <shipsing@redhat.com>
@shipsing shipsing requested review from dgolovin and axel7083 and removed request for a team September 16, 2024 10:40
Signed-off-by: Shipra Singh <shipsing@redhat.com>
Signed-off-by: Shipra Singh <shipsing@redhat.com>
Signed-off-by: Shipra Singh <shipsing@redhat.com>
Signed-off-by: Shipra Singh <shipsing@redhat.com>
Signed-off-by: Shipra Singh <shipsing@redhat.com>
@shipsing
Copy link
Contributor Author

shipsing commented Sep 30, 2024

Thank you, @benoitf @Firewall, for your valuable suggestions. I have incorporated all of them. Please verify and confirm.

I do have a query:
Since we now have a separate Docker Compatibility page in the UI, Do we need these sections, section1 and section2, which discuss about manual procedures to emulate Docker CLI and verify your socket connection. If no, should we remove them from the doc??

@Firewall
Copy link

Thanks @shipsing this is looking great.

Since we now have a separate Docker Compatibility page in the UI, Do we need these sections, section1 and section2, which discuss about manual procedures to emulate Docker CLI and verify your socket connection. If no, should we remove them from the doc??

Yep, I think those pages can be updated once the UI is updated (#8337) because those both will be able to be done from the UI. However, I would wait until the UI is done. I created a issue so we don't forget but we can still merge this PR in the meantime. Issue: #9138.

Signed-off-by: Shipra Singh <shipsing@redhat.com>
@shipsing shipsing merged commit c4c14b8 into podman-desktop:main Oct 1, 2024
17 of 18 checks passed
@shipsing
Copy link
Contributor Author

shipsing commented Oct 1, 2024

Merged the PR @Firewall. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants