Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add default actions for Pods empty state #8963

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: add default actions for Pods empty state #8963

merged 1 commit into from
Sep 24, 2024

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented Sep 19, 2024 •
edited
Loading

What does this PR do?

Adds button 'Start my first pod' to Pods page empty screen

Screenshot / video of UI

Screen.Recording.2024-09-23.at.1.59.26.PM.mov

What issues does this PR fix or reference?

Fix #8570.

How to test this PR?

  • Tests are covering the bug fix or the new feature

@dgolovin dgolovin requested review from benoitf and a team as code owners September 19, 2024 05:37
@dgolovin dgolovin requested review from cdrage, feloy and axel7083 and removed request for a team September 19, 2024 05:37
@dgolovin dgolovin requested a review from feloy September 20, 2024 00:19
feloy
feloy approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't find very demonstrative to start a pod with only the infra container. I think it would be better to start a pod with some payload

@dgolovin
Copy link
Contributor Author

LGTM

I don't find very demonstrative to start a pod with only the infra container. I think it would be better to start a pod with some payload

Sounds good to me, because without payload even terminal cannot function. Will look into it.

@benoitf
Copy link
Collaborator

benoitf commented Sep 23, 2024

setting draft mode as there will be changes

@benoitf benoitf marked this pull request as draft September 23, 2024 10:21
@dgolovin
feat: add 'Start my first pod' button for empty pods list page
186671f 
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
@dgolovin dgolovin marked this pull request as ready for review September 23, 2024 21:01
@dgolovin dgolovin requested a review from feloy September 23, 2024 21:01
feloy
feloy approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for adding the hello container

@dgolovin dgolovin merged commit f80ae0f into podman-desktop:main Sep 24, 2024
15 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.13.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@cdrage cdrage Awaiting requested review from cdrage cdrage was automatically assigned from containers/podman-desktop-reviewers

@axel7083 axel7083 Awaiting requested review from axel7083 axel7083 was automatically assigned from containers/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Default actions for Pods empty state
4 participants
@dgolovin @benoitf @feloy @podman-desktop-bot