-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display Kubernetes empty page when no current context #8989
feat: display Kubernetes empty page when no current context #8989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on Fedora
I like the iterations but IMHO it should be applied in some of reverse order.
IMHO the filtering is a pre-requisites before showing the link to the available extensions On the page showed by the PR, I would expect maybe a note just on the top of the catalog explaining why it's displayed. kind of sentence : |
Signed-off-by: Philippe Martin <phmartin@redhat.com>
9a787a1
to
cd462e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it is to be reviewed as it is a draft
No, there is still work to do on this PR |
Signed-off-by: Philippe Martin <phmartin@redhat.com>
cd462e0
to
4bce304
Compare
Signed-off-by: Philippe Martin <phmartin@redhat.com>
The features are now ready for review |
Signed-off-by: Philippe Martin <phmartin@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + nits
Co-authored-by: Denis Golovin <dgolovin@users.noreply.github.com> Signed-off-by: Philippe Martin <feloy1@gmail.com>
35cac5b
to
70a1eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
The logic should be the same as the "Create new..." button in the Resources page, for Minikube. Is the button visible there? I have seen the same behaviour with another provider, where the button was not visible because a resource was already declared. Perhaps you already have a minikube cluster running? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a feedback, I think my eyes are more seeing the installation of other extensions than seeing the ability to already being able to create a cluster.
I don't know if we could balance more the upper part or add some divider between the top and bottom screen, or making more appealing the links to create a cluster
but it could be follow-up as it's a personal view.
Oh yeah, the minikube executable is not installed, therefore cannot create a cluster. That's a bit problematic, as when the user click for the first time to install the extension it would not allow him to directly create the cluster, since it would need to download the CLI first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In line with @benoitf comments, having more focus on Create would be nice
@ekidneyrh would you have some advice to make the first part more visible? |
Signed-off-by: Philippe Martin phmartin@redhat.com
What does this PR do?
Display Kubernetes empty page when no current context
Part of #8571, see #8571 (comment) for next steps
Screenshot / video of UI
kubernetes-empty-page.mp4
What issues does this PR fix or reference?
Part of #8571
There is a glitch on the Download button after the download is finished and the extension is removed from the list (the button of the next extension is displayed as Downloading for a second). Visible in the video around 0:16. The fix will be done as part of another PR
How to test this PR?