chore: fix invalid test #9000
Merged
chore: fix invalid test #9000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createKey is not a property, it is called operationKey then tests are failing when using the correct values also, as the store is not reset across the tests, there were some dependencies between the order of the tests fix that by initializing the getConfigurationValue mock related to podman-desktop#8814 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
cdrage,
deboer-tim and
gastoner
and removed request for
a team
deboer-tim
approved these changes
Sep 21, 2024
cbr7
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
createKey is not a property, it is called operationKey then tests are failing when using the correct values
also, as the store is not reset across the tests, there were some dependencies between the order of the tests
fix that also by initializing the getConfigurationValue mock
Screenshot / video of UI
What issues does this PR fix or reference?
related to #8814
How to test this PR?