Adapts CSIu input protocol to match how recent fish shell implementation transmits it. #1807
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianparpart
added
the
VT: Backend
christianparpart
force-pushed
the
fix/fish-shell-CSIu
branch
from
3354436 to
399f471
Compare
Yaraslaut
reviewed
Nov 25, 2025
Member
Yaraslaut
left a comment
Yaraslaut
left a comment
There was a problem hiding this comment.
Hmmmmmm, shell specific handling
maybe we can figure out what should be the default value
Member
Author
I've tested kitty and ghostty. Turns out they all also behave like this, even though I did not find this in the document, they've implemented it like this. So I think it's good to go. |
…ion transmits it. However, I cannot really read that behaviour from https://sw.kovidgoyal.net/kitty/keyboard-protocol/ There was no example showing `CSI = u` nor `CSI = 5 u` without first entering CSIu mode. It seems like fish shell is tweaking CSIu mode by setting/resetting without entering/leaving. The given spec however also does not mention flags to default to 0 neither. Signed-off-by: Christian Parpart <christian@parpart.family>
christianparpart
force-pushed
the
fix/fish-shell-CSIu
branch
from
399f471 to
3dc2337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However, I cannot really read that behaviour from https://sw.kovidgoyal.net/kitty/keyboard-protocol/
There was no example showing
CSI = unorCSI = 5 uwithout first entering CSIu mode.It seems like fish shell is tweaking CSIu mode by setting/resetting without entering/leaving.
The given spec however also does not mention flags to default to 0 neither.
--
It MAY be that other CLI applications may also not enter/leave and just set/reset flags, so I think it MAY be good to have in anyways.
This may also relate to #1776. @mrdgo, if it is possible at all, maybe you want to give this branch a try?