Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimist parsing error #184

Open
tylergets opened this issue Jun 25, 2020 · 6 comments
Open

Minimist parsing error #184

tylergets opened this issue Jun 25, 2020 · 6 comments

Comments

@tylergets
Copy link

tylergets commented Jun 25, 2020

Seeing a random error on our deployments, will continue to dig deeper.

					throw new TypeError(`Expected "${key}" default value to be of type "${expectedType}", got ${prettyPrint(defaultType)}`);
					^

TypeError: Expected "verbose" default value to be of type "boolean", got "string"
    at /usr/local/lib/node_modules/conventional-github-releaser/node_modules/minimist-options/index.js:101:12
    at Array.forEach (<anonymous>)
    at buildOptions (/usr/local/lib/node_modules/conventional-github-releaser/node_modules/minimist-options/index.js:64:23)
    at meow (/usr/local/lib/node_modules/conventional-github-releaser/node_modules/meow/index.js:136:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/conventional-github-releaser/src/cli.js:9:13)
    at Module._compile (internal/modules/cjs/loader.js:1138:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
##[error]Process completed with exit code 1.```
@csakbalint
Copy link

We are having the same issue? Any new information about this?

@csakbalint
Copy link

The latest patch (4.0.2) of conventional-gitlab-releaser breaks the release process. I fixed the version to the previous one.

@jimlindeman
Copy link
Contributor

The specific error on this is in the usage help verbose definition in the src/cli.js:

    verbose: {
      alias: 'v',
      default: 'false',
      type: 'boolean'
    },

should be

    verbose: {
      alias: 'v',
      default: false,
      type: 'boolean'
    },

@jimlindeman
Copy link
Contributor

Please patch this asap, as those fetching latest of this package are broken and will have to hardlink to 3.1.3.

@jimlindeman
Copy link
Contributor

This is actually a long standing bug, but only exposed as a problem with the update to newer 'meow' package as part of
https://www.npmjs.com/package/conventional-gitlab-releaser/v/4.0.2 , which started type-checking the default value passed in.

@jimlindeman
Copy link
Contributor

PR for fix for this:
#185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants