Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqbot should allow minimization from the checks tab #185

Open
JasonGross opened this issue Dec 14, 2021 · 1 comment
Open

coqbot should allow minimization from the checks tab #185

JasonGross opened this issue Dec 14, 2021 · 1 comment
Assignees
Labels
bug minimizer enhancement New feature or request

Comments

@JasonGross
Copy link
Member

In addition to posting comments, and perhaps even when the test-suite fails, each failure in the checks tab (example) could get a line that says something like "🚀 Click here to minimize this failure". The overall checks/pipeline tab could get something like " 🚀 Click here to minimize all suggested failures" (maybe with a list of the ones that will be minimized?) and maybe " 🚀 💥 Click here to minimize all failures, including those that are not suggested" (maybe with a list of the ones that will be minimized?) The link could be a POST (or GET?) request to coqbot. It would be nice to have #184 in place before this.

@Zimmi48
Copy link
Member

Zimmi48 commented Dec 27, 2021

There is probably some logic that can be shared between the step when a job finishes and we want to inform the user that the base job has not failed and this is a candidate for minimization, and the step when a pipleine finishes and we prepare the comment suggesting minimization. This is something that we can pair code with Jason.

Apart from this there is also some implementation to do to make it possible to just minimize by clicking on a link. Or we can include a custom further action in the result of the check run: https://docs.github.com/en/rest/reference/checks#create-a-check-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug minimizer enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants