display duplicate email message from SSO in network error prompts

Author: nick-funk

client/src/core/client/framework/lib/errors/relayNetworkRequestError.ts

@@ -3,6 +3,80 @@ import { RRNLRequestError } from "react-relay-network-modern/es";
 
 import { getMessage } from "../i18n";
 
+interface DupErrorObj {
+  error?: {
+    traceID: string;
+    code: string;
+    message: string;
+  };
+}
+
+const parseDuplicateEmailError = (
+  error: RRNLRequestError
+): DupErrorObj | null => {
+  if (!error.res || error.res.status !== 403 || !error.res.text) {
+    return null;
+  }
+
+  try {
+    const json = JSON.parse(error.res.text) as DupErrorObj;
+    if (!json || !json.error || json.error.code !== "DUPLICATE_EMAIL") {
+      return null;
+    }
+
+    return json;
+  } catch {
+    return null;
+  }
+};
+
+const computeCodeMessage = (
+  error: RRNLRequestError,
+  localeBundles: FluentBundle[]
+) => {
+  if (!error.res) {
+    return "";
+  }
+
+  const codePrefix = getMessage(
+    localeBundles,
+    "framework-error-relayNetworkRequestError-code",
+    "Code"
+  );
+
+  let msg = `[${codePrefix}]`;
+  if (error.res && error.res.status) {
+    msg += ` ${error.res.status.toString()}`;
+  }
+  if (error.res && error.res.statusText) {
+    msg += ` ${error.res.statusText}`;
+  }
+
+  return msg;
+};
+
+const computeMessage = (
+  error: RRNLRequestError,
+  localeBundles: FluentBundle[]
+): string => {
+  const defaultMessage = getMessage(
+    localeBundles,
+    "framework-error-relayNetworkRequestError-anUnexpectedNetworkError",
+    "An unexpected network error occured, please try again later."
+  );
+
+  const dupeEmail = parseDuplicateEmailError(error);
+  if (dupeEmail && dupeEmail.error) {
+    return dupeEmail.error.message;
+  }
+
+  if (error.res) {
+    return `${defaultMessage} ${computeCodeMessage(error, localeBundles)}`;
+  }
+
+  return defaultMessage;
+};
+
 /**
  * RelayNetworkRequestError wraps Request errors thrown by Relay Network Layer.
  */
@@ -11,26 +85,7 @@ export default class RelayNetworkRequestError extends Error {
   public origin: RRNLRequestError;
 
   constructor(error: RRNLRequestError, localeBundles: FluentBundle[]) {
-    let msg = getMessage(
-      localeBundles,
-      "framework-error-relayNetworkRequestError-anUnexpectedNetworkError",
-      "An unexpected network error occured, please try again later."
-    );
-
-    if (error.res) {
-      const codePrefix = getMessage(
-        localeBundles,
-        "framework-error-relayNetworkRequestError-code",
-        "Code"
-      );
-
-      msg += ` [${codePrefix}: ${error.res.status.toString()}`;
-      if (error.res.statusText) {
-        msg += " " + error.res.statusText;
-      }
-      msg += "]";
-    }
-    super(msg);
+    super(computeMessage(error, localeBundles));
 
     // Maintains proper stack trace for where our error was thrown.
     if (Error.captureStackTrace) {

server/src/core/server/errors/index.ts

@@ -318,7 +318,11 @@ export class DuplicateSiteAllowedOriginError extends CoralError {
 
 export class DuplicateEmailError extends CoralError {
   constructor(email: string) {
-    super({ code: ERROR_CODES.DUPLICATE_EMAIL, context: { pvt: { email } } });
+    super({
+      code: ERROR_CODES.DUPLICATE_EMAIL,
+      context: { pvt: { email } },
+      status: 403,
+    });
   }
 }