From 8af20c9ae3c1dd133b18c4af5bf8fa2daf6677f6 Mon Sep 17 00:00:00 2001 From: Matteo Pace Date: Fri, 9 Aug 2024 13:08:45 +0200 Subject: [PATCH] Fix timeout to make CI work --- testing/coreruleset/albedo_test.go | 1 + testing/coreruleset/coreruleset_test.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/testing/coreruleset/albedo_test.go b/testing/coreruleset/albedo_test.go index e4ff4dac..98066061 100644 --- a/testing/coreruleset/albedo_test.go +++ b/testing/coreruleset/albedo_test.go @@ -30,6 +30,7 @@ type reflectionSpec struct { } func handleReflect(t testing.TB, w http.ResponseWriter, r *http.Request) { + t.Helper() log.Println("Received reflection request") body, err := io.ReadAll(r.Body) diff --git a/testing/coreruleset/coreruleset_test.go b/testing/coreruleset/coreruleset_test.go index 925a5bb3..8b06dae9 100644 --- a/testing/coreruleset/coreruleset_test.go +++ b/testing/coreruleset/coreruleset_test.go @@ -279,8 +279,8 @@ SecRule REQUEST_HEADERS:X-CRS-Test "@rx ^.*$" \ // Tests would not just be ignored, but new expectations would be set for the specific platform // E.g. see https://github.com/coreruleset/coreruleset/blob/main/tests/regression/nginx-overrides.yaml res, err := runner.Run(cfg, tests, runner.RunnerConfig{ - ShowTime: false, - ConnectTimeout: 10 * time.Second, // WIP: Defaults to 3s but looks to be not enough + ShowTime: false, + ReadTimeout: 3 * time.Second, // Defaults to 1s but looks to be not enough in the CI }, output.NewOutput("quiet", os.Stdout)) if err != nil { t.Fatal(err)