You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 15, 2020. It is now read-only.
After opening a few issues I realised that what is actually required is a a proper code review of the two recent sample projects.
There are over 15 commit messages that basically say "update" and don't provide any further information which then requires you to diff the commit to work out what is going on.
Code is not formatted to kotlin code styles (sometimes including large numbers of extra white space lines) .
Test classes are empty or partially created.
There are spelling mistakes in the class fields val amout: String,
There is a weird mix of commenting styles instead of proper kdocs
e.g.
// *********
// * State *
//
Plus the other issues like binary files and eclipse project files being checked in.
This should have come in via a pull request instead of direct commit so that the issues could have been caught before being added to the project.
After opening a few issues I realised that what is actually required is a a proper code review of the two recent sample projects.
There are over 15 commit messages that basically say "update" and don't provide any further information which then requires you to diff the commit to work out what is going on.
Code is not formatted to kotlin code styles (sometimes including large numbers of extra white space lines) .
Test classes are empty or partially created.
There are spelling mistakes in the class fields
val amout: String,
There is a weird mix of commenting styles instead of proper kdocs
e.g.
Plus the other issues like binary files and eclipse project files being checked in.
This should have come in via a pull request instead of direct commit so that the issues could have been caught before being added to the project.
Other recent issues for reference:
#67
#68
#69
The text was updated successfully, but these errors were encountered: