Skip to content
This repository has been archived by the owner on May 15, 2020. It is now read-only.

Code Review Recent Samples #70

Closed
opticyclic opened this issue Nov 19, 2019 · 1 comment
Closed

Code Review Recent Samples #70

opticyclic opened this issue Nov 19, 2019 · 1 comment

Comments

@opticyclic
Copy link
Contributor

After opening a few issues I realised that what is actually required is a a proper code review of the two recent sample projects.

There are over 15 commit messages that basically say "update" and don't provide any further information which then requires you to diff the commit to work out what is going on.

Code is not formatted to kotlin code styles (sometimes including large numbers of extra white space lines) .

Test classes are empty or partially created.

There are spelling mistakes in the class fields val amout: String,

There is a weird mix of commenting styles instead of proper kdocs
e.g.

// *********
// * State *
//

Plus the other issues like binary files and eclipse project files being checked in.

This should have come in via a pull request instead of direct commit so that the issues could have been caught before being added to the project.

Other recent issues for reference:

#67
#68
#69

@anthonykeenan
Copy link
Contributor

We've backed out those changes and created a PR for it so you can comment there #73

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants