Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

\r processed as literal in double quoted strings #359

Open
theseion opened this issue Sep 22, 2024 · 1 comment
Open

\r processed as literal in double quoted strings #359

theseion opened this issue Sep 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@theseion
Copy link
Collaborator

goccy/go-yam has only recently added processing of \r in double quoted strings. We need to upgrade goccy/go-yaml but are currently blocked due to the performance impact solved by goccy/go-yaml#438.
@theseion theseion added the bug Something isn't working label Sep 22, 2024
@theseion theseion mentioned this issue Sep 22, 2024
Open
theseion added a commit to theseion/go-ftw that referenced this issue Nov 10, 2024
@theseion
chore: add test for YAML unmarshalling
2a425d6 
The new tests specifically test unmarshalling of line feed and carriage
return escape sequences in double qouted strings, as that was an issue
with goccy/go-yaml.

Refs coreruleset#359
@theseion
Copy link
Collaborator Author

Fixed by #375

@theseion theseion mentioned this issue Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theseion