DataObjectBatchListing ignores ->setOffset()

[hethehe]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	no
RFC?	no

If we create a Listing and set a offset with $listing->setOffset(100) and use it with the CoreShop\Component\Pimcore\BatchProcessing\DataObjectBatchListing it gets ignored.

I think the problem is that you get the loadIdList() and the getTotalCount() from the DAO instead directly from the $list

Is there a special reason you use the $dao instead the $list directly?

[dpfaffenbauer]

@hethehe honestly, not sure... we never actually had in mind that the BatchList can use a offset :D.

[hethehe]

@dpfaffenbauer We tried to set an offset for the coreshop:index command, as sometimes it would be nice not to include all products ;)

Are you interested in a PR that changes the $dao to $list? I don't see anything that could break, WDYT?

[dpfaffenbauer]

@hethehe yes, we are interested. it should be tested anyway, maybe you can add another test for offests?

[hethehe]

Just realized, that this is not a problem of your BatchListing but from Pimcore's getTotalCount()
see: pimcore/pimcore#17618

[dpfaffenbauer]

gotcha, then we can close this?

[hethehe]

yes, closed

[kingjia90]

Can this issue be opened again please?
I believe the initial issue would be fixed if we replace getTotalCount() to getCount() in there

CoreShop/src/CoreShop/Component/Pimcore/BatchProcessing/DataObjectBatchListing.php

Lines 86 to 94 in 38d6eca

	if (!method_exists($dao, 'getTotalCount')) {
	throw new \InvalidArgumentException(sprintf(
	'%s listing class does not support count.',
	$this->list::class,
	));
	}
	/** @psalm-suppress InternalMethod */
	$this->total = $dao->getTotalCount();

see also pimcore/pimcore#17618 (comment)

[dpfaffenbauer]

@hethehe can you give it a test?