use getCount() instead of getTotalCount() for BatchListing #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
@hethehe the feature is only partly tested in index generation. can you add another test? please also sign the cla (we changed the CLA workflow and it has to be resigned now) |
…for BatchListing I have read the CLA Document and I hereby sign the CLA
|
Busy day yesterday... |
|
I have read the CLA Document and I hereby sign the CLA |
|
@hethehe ok, I'll check then |
|
@hethehe tests added |
dpfaffenbauer
approved these changes
Sep 20, 2024
|
|
@hethehe many thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use getCount() instead of getTotalCount() for BatchListing because getTotalCount ignores limit and offset.