diff --git a/backend/src/types/DataTypes.d.ts b/backend/src/types/DataTypes.d.ts
index a9bd66cab..34bfb1601 100644
--- a/backend/src/types/DataTypes.d.ts
+++ b/backend/src/types/DataTypes.d.ts
@@ -81,6 +81,9 @@ export type DBDevPortfolioSubmission = {
member: firestore.DocumentReference;
openedPRs: PullRequestSubmission[];
reviewedPRs: PullRequestSubmission[];
+ isLate?: boolean;
+ text?: string;
+ documentationText?: string;
status: SubmissionStatus;
};
diff --git a/common-types/index.d.ts b/common-types/index.d.ts
index 017a30bcc..d4e5e0313 100644
--- a/common-types/index.d.ts
+++ b/common-types/index.d.ts
@@ -162,6 +162,7 @@ interface DevPortfolioSubmission {
reviewedPRs: PullRequestSubmission[];
isLate?: boolean;
text?: string;
+ documentationText?: string;
status: SubmissionStatus;
}
diff --git a/frontend/src/components/Admin/DevPortfolio/DevPortfolioDetails.tsx b/frontend/src/components/Admin/DevPortfolio/DevPortfolioDetails.tsx
index 02cc83ce1..3a50604be 100644
--- a/frontend/src/components/Admin/DevPortfolio/DevPortfolioDetails.tsx
+++ b/frontend/src/components/Admin/DevPortfolio/DevPortfolioDetails.tsx
@@ -186,6 +186,7 @@ const DetailsTable: React.FC = ({ portfolio, isAd
Name
Opened PRs
Reviewed PRs
+ Documentation
Status
{sortedSubmissions.some((submission) => submission.text) && (
@@ -256,6 +257,7 @@ const SubmissionDetails: React.FC = ({
prSubmission={submission.reviewedPRs.length > 0 ? submission.reviewedPRs[0] : undefined}
/>
+ {submission.documentationText}
{isAdminView ? (
@@ -320,6 +322,7 @@ const SubmissionDetails: React.FC = ({
prSubmission={i >= remainingReviewedPRs.length ? undefined : remainingReviewedPRs[i]}
/>
+
{!submission.text ? : <>>}
));
diff --git a/frontend/src/components/Forms/DevPortfolioForm/DevPortfolioForm.tsx b/frontend/src/components/Forms/DevPortfolioForm/DevPortfolioForm.tsx
index a823e4e8c..b322b062a 100644
--- a/frontend/src/components/Forms/DevPortfolioForm/DevPortfolioForm.tsx
+++ b/frontend/src/components/Forms/DevPortfolioForm/DevPortfolioForm.tsx
@@ -20,6 +20,7 @@ const DevPortfolioForm: React.FC = () => {
const [reviewPRs, setReviewedPRs] = useState(['']);
const [isLoading, setIsLoading] = useState(true);
const [text, setText] = useState(undefined);
+ const [documentationText, setDocumentationText] = useState('');
useEffect(() => {
refreshDevPortfolios();
@@ -93,6 +94,11 @@ const DevPortfolioForm: React.FC = () => {
headerMsg: 'Paragraph Submission Empty',
contentMsg: 'Please write something for the paragraph section of the assignment.'
});
+ } else if (!documentationText) {
+ Emitters.generalError.emit({
+ headerMsg: 'Documentation Empty',
+ contentMsg: 'Please write something for the documentation section of the assignment.'
+ });
} else if (new Date(latestDeadline) < new Date()) {
Emitters.generalError.emit({
headerMsg: 'The deadline for this dev portfolio has passed',
@@ -115,6 +121,7 @@ const DevPortfolioForm: React.FC = () => {
status: 'pending'
})),
status: 'pending',
+ documentationText,
...(text && { text })
};
sendSubmissionRequest(newDevPortfolioSubmission, devPortfolio);
@@ -180,7 +187,7 @@ const DevPortfolioForm: React.FC = () => {
2. What did the team do the past two weeks?
-
+