Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Booster shot with BioNTech on J&J shows "wait X days until completed" text #777

Open
2 of 3 tasks
reckter opened this issue Nov 9, 2021 · 17 comments
Open
2 of 3 tasks
Assignees
Labels
bug Something isn't working mirrored-to-jira This item is also tracked internally in JIRA

Comments

@reckter
Copy link

reckter commented Nov 9, 2021

Avoid duplicates

  • Bug is not mentioned in the FAQ
  • Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
    => I can not test on Android, so idk, happy to move this issue, when necessary.
  • Bug is not already reported in another issue

Technical details

  • Device name: iPhone 12 pro
  • iOS version: 15.1
  • App version: 2.13.1 (0)

Describe the bug

After importing a booster-shot certificate for BioNTech, while already having a J&J certificate imported the app shows the text in the picture below on the certificate screen. All other information on the screen still correctly reflect the first successful vaccination though. It also states that it only uses the J&J certificate as the main one.

IMG_967E9B456B34-1

Steps to reproduce the issue

Upload the booster certificate no later then 14 days after the vaccination.

Expected behaviour

I would have expected to not see the text.
I might misinterpret the text, but as it's only the booster vaccination my certificate should be valid in these 14 days as well, which is not reflected in the text.

Possible Fix

Probably the easiest fix is to not display the text, when the certification without the last vaccination shot is sufficient.

Additional context


Internal Tracking ID: EXPOSUREAPP-10993 + EXPOSUREAPP-11043

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Nov 9, 2021

The problem, that a Biontech Booster ("2/2") on J&J is only valid after 14 days, is known and can't be fixed, see Digitaler-Impfnachweis/certification-apis#198.

The app shows this text because it can't differentiate between a normal "2/2" Biontech shot and a "2/2" Biontech Booster shot.

@reckter
Copy link
Author

reckter commented Nov 9, 2021

@Ein-Tim Ah thank you.
But can't you distinguish between BioNTech on J&J and biontech "normal" vaccination, by the numbers?
Shouldn't biotech be 2/2 after 1/2? instead of 2/2 on 1/1? Or am I mistaken there?

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Nov 9, 2021

@reckter

Each certificate has to be "looked at" independently of any other certificates, because the EU rules only allow "one event in one certificate".

The problem wouldn't be to hide the message you are seeing for everyone who got a Biontech "2/2" certificate and a Jansen & Jansen "1/1" certificate, this would just be looking at the certificates you've stored in your app and hiding this message.
However, this wouldn't make your "2/2" certificate valid, so it makes no sense to do this.

Hope this was clear?

@dsarkar
Copy link
Member

dsarkar commented Nov 9, 2021

@reckter In principle one could include a logic onto the CWA, can can recognise a 2/2 BioNTech/Moderna certificate as a booster vaccination, if CWA finds a 1/1 J&J certificate in the "wallet". As pointed out by @Ein-Tim, the issue would still persist, since a CheckApp (in Germany CovPassCheck-App) only scans one certificate, it cannot conclude if it is a booster vaccination or the completion of a series of vaccination (Grundimmunisierung).

The workaround for users with a 1/1-J&J vaccination is to present for checking in the first 14 days the J&J certificate and the 2/2 booster certificate.

@reckter
Copy link
Author

reckter commented Nov 10, 2021

The workaround for users with a 1/1-J&J vaccination is to present for checking in the first 14 days the J&J certificate and the 2/2 booster certificate.

As far as I can tell, this is what the CWA, currently does as well, correct?
I still stand by my point coming from the user perspective:
Effectively the app is telling me that my vaccination is not completed yet, when in fact it is.
I think hiding the text, and choosing the correct certificate to show in the QR code, dependent on the date, is the most user friendly approach.

The problem wouldn't be to hide the message you are seeing for everyone who got a Biontech "2/2" certificate and a Jansen & Jansen "1/1" certificate, this would just be looking at the certificates you've stored in your app and hiding this message.
However, this wouldn't make your "2/2" certificate valid, so it makes no sense to do this.

My underlying problem is, that I do have valid vaccination coverage, but the app is suggesting me that I currently do not have that.
I understand the technical reasons now (thank for explaining, much appreciated!), even though I think the message should be altered to not confuse users who do not know these reasons.

Explaining why the new certificate will only be shown in X days is my preferred solution currently ("Your newest certificate is valid in X days, until then the app will show your previous, still valid, certificate" or so).

All that aside, this is not an app braking bug or anything.

@ndegendogo
Copy link

ndegendogo commented Nov 10, 2021

Each certificate has to be "looked at" independently of any other certificates, because the EU rules only allow "one event in one certificate".

In principle one could include a logic onto the CWA, can can recognise a 2/2 BioNTech/Moderna certificate as a booster vaccination, if CWA finds a 1/1 J&J certificate in the "wallet". As pointed out by @Ein-Tim, the issue would still persist, since a CheckApp (in Germany CovPassCheck-App) only scans one certificate, it cannot conclude if it is a booster vaccination or the completion of a series of vaccination (Grundimmunisierung).

@Ein-Tim @dsarkar I don't know how this check is implemented in the app; but as a user, I would expect the following:

  • check each certificate independently against the downloaded business rules (I guess the question could remain, which business rules, as each country has its own rules ...)
  • don't "invent" cwa-specific additional rules - this could make the logic inconsistent and fragile (and, after all, the "master" is CovPassCheck)
  • If there are several certificates for the same person, combine their results. If at least one is valid, the overall status for that person is valid.

Does this make sense?

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Dec 4, 2021

@ndegendogo

AFAIK this is how it's done since version 2.13.2. Do you have a way to confirm this?

@reckter For the reasons mentioned above this issue can't be fixed on CWA side, thus I think it doesn't really make sense to leave this issue open any longer, or?

@dsarkar I suggest to apply the won't fix label here or create a new can't fix label and apply it here.

@ndegendogo
Copy link

AFAIK this is how it's done since version 2.13.2. Do you have a way to confirm this?

@Ein-Tim I guess reading the code ... maybe another day 🙃

@moabits
Copy link

moabits commented Dec 5, 2021

I don't think a "wontfix" is a solution here, at least the text in the app should be changed to include this information.
Something like in the CovPass FAQ: https://twitter.com/achisto/status/1467516734907293710

@dsarkar
Copy link
Member

dsarkar commented Dec 5, 2021

@moabits see also https://www.coronawarn.app/de/faq/#vac_booster_jj. @Ein-Tim do you want to create a wishlist item, that such information should be shown in the app, or maybe even better, a link to this (or another) FAQ article in the vaccination status box?

@reckter
Copy link
Author

reckter commented Dec 6, 2021

I agree with @moabits. If there isn"t a ticket in the right place, to get this fixed it should be created, and we can use this as a tracking for that. (I whole heartedly agree though, that as a maintainer of the cwa such tickets are frustrating, because you can't actively fix them)

AFAIK this is how it's done since version 2.13.2. Do you have a way to confirm this?

if that's the case, then we can close this as fixed :D

Looking at these lines: It seems like it's at least fixed in the Compass app: https://github.com/Digitaler-Impfnachweis/covpass-ios/blob/67278c30862e601131c01503331e3cf04bf3776b/Source/CovPassCommon/Sources/CovPassCommon/Models/Vaccination.swift#L32
But I have no idea about that code, or the inner workings of cwa and covpass, so I can't pass a final judgement. (and of course I can't test it either ^^)

@moabits
Copy link

moabits commented Dec 14, 2021

@svengabr
Copy link
Member

Not creating a new Jira ticket at this point but this one is getting added to our ongoing hot-topic discussion that is already active in Jira. The team is aware of this issue and actively trying to find a solution for this issue.

EXPOSUREAPP-10993
EXPOSUREAPP-11043

The EU has currently declined a 3 of 3 vaccination approach to fix this issue. There is a discussion going on how a "Germany-Wide" solution could be implemented in the meantime.

We have already published a faq article here:
https://www.coronawarn.app/de/faq/#vac_booster_jj

@svengabr
Copy link
Member

Internal Tracking ID: EXPOSUREAPP-10993 + EXPOSUREAPP-11043

@svengabr svengabr transferred this issue from corona-warn-app/cwa-app-ios Dec 16, 2021
@svengabr
Copy link
Member

Moved to cwa-documentation since this issue is not iOS specific but also affects Android

@svengabr svengabr added mirrored-to-jira This item is also tracked internally in JIRA bug Something isn't working labels Dec 16, 2021
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Dec 25, 2021

FYI: https://ec.europa.eu/commission/presscorner/detail/en/ip_21_6837 says:

"Boosters will be recorded as follows:

3/3 for a booster dose following a primary 2-dose vaccination series.
2/1 for a booster dose following a single-dose vaccination or a one dose of a 2-dose vaccine administered to a recovered person."

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Apr 18, 2022

@reckter This issue has been fixed with the new enumeration (2/1), so this issue can be closed as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
Development

No branches or pull requests

7 participants