provenance comment

Author: alfC

include/boost/multi/adaptors/thrust/test/CMakeLists.txt

@@ -29,13 +29,13 @@ if(NOT Boost_FOUND)
 endif()
 
 set(TEST_SRCS
-    array.cu
-    memory_resource.cu
+	array.cu
+	memory_resource.cu
 	run_reduce.cu
 	set_identity_kernel.cu
-    speed.cu
-    speed_algo.cu
-    universal.cu
+	speed.cu
+	speed_algo.cu
+	universal.cu
 	vector.cu
 )
 

include/boost/multi/array_ref.hpp

@@ -431,7 +431,7 @@ struct subarray_ptr  // NOLINT(fuchsia-multiple-inheritance) : to allow mixin CR
 		std::enable_if_t<!std::is_base_of_v<subarray_ptr, subarray_ptr<OtherT, OtherD, OtherEPtr, OtherL, OtherIsConst>>, int> =0  // NOLINT(modernize-use-constraints)  TODO(correaa) for C++20
 	>
 	friend BOOST_MULTI_HD constexpr auto operator==(subarray_ptr const& self, subarray_ptr<OtherT, OtherD, OtherEPtr, OtherL, OtherIsConst> const& other) -> bool {
-		assert((!self || !other) || (self->layout() == other->layout())); 
+		assert((!self || !other) || (self->layout() == other->layout()));  // comparing array ptrs of different provenance is undefined
 		return self->base() == other->base();
 	}
 
@@ -440,7 +440,7 @@ struct subarray_ptr  // NOLINT(fuchsia-multiple-inheritance) : to allow mixin CR
 		std::enable_if_t<!std::is_base_of_v<subarray_ptr, subarray_ptr<OtherT, OtherD, OtherEPtr, OtherL, OtherIsConst>>, int> =0  // NOLINT(modernize-use-constraints)  TODO(correaa) for C++20
 	>
 	friend BOOST_MULTI_HD constexpr auto operator!=(subarray_ptr const& self, subarray_ptr<OtherT, OtherD, OtherEPtr, OtherL, OtherIsConst> const& other) -> bool {
-		assert((!self || !other) || (self->layout() == other->layout())); 
+		assert((!self || !other) || (self->layout() == other->layout()));  // comparing array ptrs of different provenance is undefined
 		return self->base() != other->base();
 	}
 

test/array_ptr.cpp

@@ -3,10 +3,10 @@
 // Distributed under the Boost Software License, Version 1.0.
 // https://www.boost.org/LICENSE_1_0.txt
 
-#include <boost/core/lightweight_test.hpp>
-
 #include <boost/multi/array.hpp>  // for layout_t, apply, subarray, array...  // IWYU pragma: keep  // bug in iwyu 8.22
 
+#include <boost/core/lightweight_test.hpp>
+
 #include <algorithm>    // for equal
 #include <array>        // for array  // IWYU pragma: keep  // bug in iwyu 8.22
 #include <memory>       // for addressof
@@ -25,11 +25,11 @@ auto main() -> int {  // NOLINT(readability-function-cognitive-complexity,bugpro
 	namespace multi = boost::multi;
 
 #ifndef _MSC_VER  // MSVC 14.40 is not constexpr ready?
-	// BOOST_AUTO_TEST_CASE(constexpr_ptr_access) {
-	//  static constexpr auto test = [] {
-	//    std::array<int, 12>      buffer{{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11}};
-	//    multi::array_ref<int, 2> arr({3, 3}, buffer.data());
-	//    auto                     ptr = &arr;
+				  // BOOST_AUTO_TEST_CASE(constexpr_ptr_access) {
+				  //  static constexpr auto test = [] {
+				  //    std::array<int, 12>      buffer{{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11}};
+				  //    multi::array_ref<int, 2> arr({3, 3}, buffer.data());
+				  //    auto                     ptr = &arr;
 
 	//    return (ptr->base() == buffer.data());
 	//  }();
@@ -90,15 +90,15 @@ auto main() -> int {  // NOLINT(readability-function-cognitive-complexity,bugpro
 		BOOST_TEST( &std::as_const(arr)[2] == &ac2 );
 		BOOST_TEST( &ac2 == &              arr [2] );
 
-		// auto pac2 = &ac2;
-		// auto parr2 = &arr[2];
-		// BOOST_TEST( pac2 == parr2 );
+		auto pac2  = &ac2;
+		auto parr2 = &arr[2];
+		BOOST_TEST( pac2 == parr2 );
 
-		// pac2 = nullptr;
-		// BOOST_TEST( pac2 != parr2 );
+		pac2 = nullptr;
+		BOOST_TEST( pac2 != parr2 );
 
-		// parr2 = nullptr;
-		// BOOST_TEST( pac2 == parr2 );
+		parr2 = nullptr;
+		BOOST_TEST( pac2 == parr2 );
 	}
 
 	BOOST_AUTO_TEST_CASE(subarray_ptr_1D) {
@@ -219,17 +219,17 @@ auto main() -> int {  // NOLINT(readability-function-cognitive-complexity,bugpro
 
 		using my_span = multi::array_ref<int, 1>;
 
-		#if defined(__clang__)
-		#pragma clang diagnostic push
-		#pragma clang diagnostic ignored "-Wunknown-warning-option"
-		#pragma clang diagnostic ignored "-Wunsafe-buffer-usage"
-		#endif
+#if defined(__clang__)
+#	pragma clang diagnostic push
+#	pragma clang diagnostic ignored "-Wunknown-warning-option"
+#	pragma clang diagnostic ignored "-Wunsafe-buffer-usage"
+#endif
 
 		auto aP = &my_span{vec.data() + 2, {5}};  // NOLINT(cppcoreguidelines-pro-bounds-pointer-arithmetic)
 
-		#if defined(__clang__)
-		#pragma clang diagnostic pop
-		#endif
+#if defined(__clang__)
+#	pragma clang diagnostic pop
+#endif
 
 		BOOST_TEST( (*aP).size() == 5 );
 		BOOST_TEST( aP->size() == 5 );  // doesn't work on MSVC?