-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable livenessprobe by default #484
Labels
enhancement
New feature or request
Comments
Also bad for compactors as confirmed today |
they also seem to be designed wrong? the ready endpoint for store-gateway returns
so store-gateway is being killed because some other service isnt ready, |
+1 We should just remove it. Should we just drop livenessProbe for store-gateway and compactor then? |
@nschad yes, please |
1 task
Sorry for the hold-up PR is open #502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have run all cortex components for years without liveness probes.
they are bad for store-gateways because it causes re-sharding if they are under pressure.
Restarting store-gateways can take a long time to recover, same for others components.
We should disable all of them by default and let users enable them as needed.
Similar to
#263
The text was updated successfully, but these errors were encountered: