Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable livenessprobe by default #484

Closed
friedrichg opened this issue Oct 10, 2023 · 5 comments · Fixed by #502
Closed

Disable livenessprobe by default #484

friedrichg opened this issue Oct 10, 2023 · 5 comments · Fixed by #502
Labels
enhancement New feature or request

Comments

@friedrichg
Copy link
Member

I have run all cortex components for years without liveness probes.
they are bad for store-gateways because it causes re-sharding if they are under pressure.
Restarting store-gateways can take a long time to recover, same for others components.
We should disable all of them by default and let users enable them as needed.

Similar to
#263

@friedrichg friedrichg added the enhancement New feature or request label Oct 10, 2023
@friedrichg
Copy link
Member Author

Also bad for compactors as confirmed today

@aep
Copy link

aep commented Jun 25, 2024

they also seem to be designed wrong?

the ready endpoint for store-gateway returns

Some services are not Running:
Running: 3
Starting: 1

so store-gateway is being killed because some other service isnt ready,
but the other service doesnt have a probe?

@nschad
Copy link
Collaborator

nschad commented Jun 26, 2024

+1

We should just remove it.

@friedrichg

Should we just drop livenessProbe for store-gateway and compactor then?

@friedrichg
Copy link
Member Author

@nschad yes, please

@nschad
Copy link
Collaborator

nschad commented Jul 1, 2024

Sorry for the hold-up

PR is open #502

@friedrichg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants