Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing the method to compute the Subject Key Identifier in Native C509 Certificate #179

Open
xipki opened this issue Apr 20, 2024 · 3 comments
Assignees
Labels

Comments

@xipki
Copy link
Contributor

xipki commented Apr 20, 2024

We need to specify the method to compute the key identifier over the public key. The method specified in RFC 5280 (https://datatracker.ietf.org/doc/html/rfc5280#section-4.2.1.2) cannot be used here, due to the possible different encoded subjectPublicKey.

For the EC public keys (Weierstraß, EdDSA, X25519/X448), the subjectPublicKeyare of the same in X509 and C509. But at least for RSA, it is different.

@xipki xipki changed the title Need the method to compute the Subject Key Identifier Missing the method to compute the Subject Key Identifier in Native C509 Certificate Apr 22, 2024
@xipki
Copy link
Contributor Author

xipki commented Jul 6, 2024

@gselander Could you add the discussion result here?

@emanjon
Copy link
Collaborator

emanjon commented Dec 19, 2024

I intended to make a PR but accidently pushed to main.
8e6decb

@emanjon
Copy link
Collaborator

emanjon commented Dec 19, 2024

Changed to

"In natively signed certificates, KeyIdentifier SHOULD be composed of the leftmost 160-bits of the SHA-256 hash of the CBOR encoded subjectPublicKey. Other methods of generating unique numbers can be used."

@xipki can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants