You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current regex treats the last digit as a ref digit, ie it uses it to multiply "N" that many times. This makes the coordinate wrong as the last digit is cut off, eg:
In [6]: HGVSName("NC_000017.11:g.50199235=")
Out[6]: HGVSName('NC_000017.11:g.5019923NNNNN=')
In [7]: HGVSName("NM_018090.5:c.462=")
Out[7]: HGVSName('NM_018090.5:c.46NN=')
Unit test test_hgvs_names.py
# Copy pasted from BRCA1:c.101A= test with "A" removed
('BRCA1:c.101=', True,
{
'gene': 'BRCA1',
'kind': 'c',
'cdna_start': CDNACoord(101),
'cdna_end': CDNACoord(101),
'ref_allele': '',
'alt_allele': '',
'mutation_type': '=',
}),
# Copy pasted from BRCA1:g.101A= test with "A" removed
('BRCA1:g.101=', True,
{
'gene': 'BRCA1',
'kind': 'g',
'start': 101,
'end': 101,
'ref_allele': '',
'alt_allele': '',
'mutation_type': '=',
}),
The current regex treats the last digit as a ref digit, ie it uses it to multiply "N" that many times. This makes the coordinate wrong as the last digit is cut off, eg:
Unit test test_hgvs_names.py
Currently fails with:
Fix is to add a new regex just above the existing "No change" regexes, ie in HGVSRegex:
I am not sure whether the protein HGVS is affected, and if need to specify the ref ie whether "p.1000=" is valid or not
The text was updated successfully, but these errors were encountered: