Skip to content

Command line arguments should match production environment #50

@brollb

Description

@brollb

The command line arguments for courseraprogramming grade local are currently passed through to the grader (with the exceptions of the docker container name and the submission directory). This allows for the user to pass incorrect arguments to this command (unintentionally) to get false positives wrt their tests.

When this is combined with the example from https://github.com/coursera/programming-assignments-demo/tree/master/custom-graders, it seems as though the only arguments to the grader are partId <id>.

courseraprogramming grade local demo_grader.v1.1 $CustomGraderPath/DemoAssignmentGrader/SampleSubmission/FactoringSampleSubmission partId HxbKF

Since the actual arguments provided are partId <id> filename <suggested name> userId <user> this is somewhat misleading (more of a problem when the documentation also has no mention of the provided arguments.

I don't mean to mix issues too much here (with the comments to the tutorial). Basically, I think it would be nice if the arguments were enforced when grading locally so there were no surprises when publishing (regardless of the documentation).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions