-
Notifications
You must be signed in to change notification settings - Fork 20
Description
The command line arguments for courseraprogramming grade local are currently passed through to the grader (with the exceptions of the docker container name and the submission directory). This allows for the user to pass incorrect arguments to this command (unintentionally) to get false positives wrt their tests.
When this is combined with the example from https://github.com/coursera/programming-assignments-demo/tree/master/custom-graders, it seems as though the only arguments to the grader are partId <id>.
courseraprogramming grade local demo_grader.v1.1 $CustomGraderPath/DemoAssignmentGrader/SampleSubmission/FactoringSampleSubmission partId HxbKFSince the actual arguments provided are partId <id> filename <suggested name> userId <user> this is somewhat misleading (more of a problem when the documentation also has no mention of the provided arguments.
I don't mean to mix issues too much here (with the comments to the tutorial). Basically, I think it would be nice if the arguments were enforced when grading locally so there were no surprises when publishing (regardless of the documentation).