-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python coverage support broken (v0.6.10 of coveralls report problem) #205
Comments
Disable coveralls until coverallsapp/github-action#205 is resolved
Hello there. I have same issue :) This is caused by PR coverallsapp/coverage-reporter#122 , but not sure - how to fix that :) |
I dropped the action and I'm just using coveralls reporter 0.6.9, which works for Python. I couldn't get 0.6.10 working, I tried using the recommended XML export and also installing the Python coverage tool, always failed. I use something like this: - name: Upload Coverage optional
env:
COVERALLS_DEBUG: true
COVERALLS_FLAG_NAME: ${{ matrix.ki_release }}_${{ matrix.w_tests }}
COVERALLS_PARALLEL: true
COVERALLS_ENDPOINT: https://coveralls.io
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_SOURCE_HEADER: github-action
run: |
mkdir -p ~/bin/
echo ~/bin >> $GITHUB_PATH
export CURDIR=`pwd`
cd ~/bin/
curl -sLO https://github.com/coverallsapp/coverage-reporter/releases/download/v0.6.9/coveralls-linux.tar.gz
curl -sLO https://github.com/coverallsapp/coverage-reporter/releases/download/v0.6.9/coveralls-checksums.txt
cat coveralls-checksums.txt | grep coveralls-linux.tar.gz | sha256sum --check
tar -xzf coveralls-linux.tar.gz
rm coveralls-checksums.txt
cd ${CURDIR}
~/bin/coveralls report --debug --format python .coverage |
Hi @set-soft. It looks like the issue might be with your last line. That is to say, there is an issue with your last line that will cause an error: ( Let me know if you have any luck with It's great that you're using the |
I also tried this (before python), didn't work.
When I tried using cobertura I got
You can see the run here I also tried removing the .coverage file here
Lamentably I didn't have debug enabled when I tried cobertura. |
Hi @set-soft. I submitted this as a potential issue with If you're concerned about getting it to work before we can have a look, I suggest renaming that directory if feasible. I'll update you here when I hear back. |
@set-soft. Follow-up clarification from my team member: When you said:
Can I confirm that you mean you removed any and all Specifically, did you remove the Thanks 🙏 |
Hi @afinetooth ! Take a look at the Upload Coverage optional (requisite) step, it does So .coverage was a file, not a directory, and was removed to avoid confusion. You can see the output of the ls command at the end of the step Collect coverage ki8 it says:
This step ran:
I never knew what directory was the problem. I tried running the same docker image in my local machine and tried to reproduce the steps, I got:
I used |
I just encountered this. I was able to work around it by specifying using lcov format also produced correct results, whereas with the default |
Sorry guys, I've been OOO. @altaurog, thanks for sharing your solution. @set-soft some good news, this PR should fix your issue and will be released soon as v. Until then, some potential mitigating actions you can take:
You said you ran this:
Csn you tell me why you used the |
Due to an issue with the coveralls coverage reporter, the generated code coverage can not be pushed to coveralls and leads to a failed integration test pipeline. Pinning the coverage reporter to v0.6.9 is the suggested workaround: coverallsapp/github-action#205 Signed-off-by: Michael Engel <mengel@redhat.com>
Due to an issue with the coveralls coverage reporter, the generated code coverage can not be pushed to coveralls and leads to a failed integration test pipeline. Pinning the coverage reporter to v0.6.9 is the suggested workaround: coverallsapp/github-action#205 Signed-off-by: Michael Engel <mengel@redhat.com>
Due to an issue with the coveralls coverage reporter, the generated code coverage can not be pushed to coveralls and leads to a failed integration test pipeline. Pinning the coverage reporter to v0.6.9 is the suggested workaround: coverallsapp/github-action#205 Signed-off-by: Michael Engel <mengel@redhat.com>
…reads (#102) * index bam before calling samtools idxstats; warn user if input lacks reads in `read_utils.py::minimap2_idxstats()`, warn the user if the input bam file lacks reads, and index the post-alignment post-filtering bam before calling `samtools idxstats` so `minimap2_idxstats()` succeeds if the input bam lacks reads. The minimap2 wrapper, `tools/minimap2.py::Minimap2::align_bam()`, tolerates empty input and indexes bam/cram output, but the post-filtering final bam in minimap2_idxstats was not being indexed, which led to a problematic exit-on-failure condition in a WDL command invoking the function. Also fix import of the InvalidBamHeaderError class used in several tool modules (add it to errors.py, and import the error subclasses where needed). This also runs minimap2 alignment when a read group lacks reads, since the newer version of minimap2 seems to better tolerate empty RGs. This allows samtools idxstats to yield zeros across the board for all input sequences when no reads are present, rather than only emitting the catchall "*" (which can cause issues downstream where metrics are expected) * add pandas to deps * attempt to fix coverage reporting due to breaking changes in coveralls reporter see: coverallsapp/coverage-reporter#124 coverallsapp/github-action#205 additional refs: https://github.com/coverallsapp/github-action?tab=readme-ov-file https://github.com/coverallsapp/coverage-reporter#supported-coverage-report-formats
Cleaning house. Gonna close this issue as it should have been resolved by If anyone disagrees, or is still having issues with |
I added lcov format as output of pytest and now it's running. I'm not sure, why it was running before 0.6.10. Without lcov, no changes are detected. |
@MarcelGeo yes, In general, we recommend exporting in Cobertura XML format, where the lines would be slightly different from your changes, as follows:
In Prior to that, and for a short time during In any case, we're on
|
Yesterday the "coveralls report" 0.6.10 was released. This started to generate the following error:
Forcing the format to python I got:
The first option seems to be impossible for an action. So I tried the second. Now I get:
I still trying things, but I think the action should fix it.
The text was updated successfully, but these errors were encountered: