-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to provide a source filepath for mono repos #11
Comments
I recently encountered a similar situation with the orb. Many of the problems I was having were related to the way CircleCI handles variables compounded by the way that our scripts are defined in our package.json files. I eventually abandoned the orb, and instead, I made a CircleCI command based on a slimmed-down version of it. The command uses the parallel feature of coveralls, and it was also executed after all tests had completed to finalize it in a similar way to the orb's method. The monorepo root package.json script definitions are prepended with To get around the issues in our fan-out, parallel testing scenario, I prepended this command: Script definition in package1's package.json:
Script definition in root package.json:
CircleCI Command:
Test Job:
Finalize Job:
Workflow jobs:
|
Hey! There is a |
I'm going to close this issue. I hope you were able to make use of the |
We have a mono repo with multiple packages working together. The tree looks similar to this
Each package has it's own test runs and own coverage files.
When I run
cat packages/package1/coverage/lcov.info | coveralls
, like the orb does, it can find the lcov informations, but the result is empty. The coverage file contains paths likesrc/views/App.js
, without the package path. So this condition results infalse
because there is nosrc/views/App.js
in the root directory.node-coveralls
has an option to provide an aditional filepath, see it here: https://github.com/nickmerwin/node-coveralls/blob/master/lib/getOptions.js#L246-L250But I can not configure the Orb to utilize this option which means I have to manually install and use node-coveralls for my circleci builds like this:
A filepath option for source files is missing in the orb configuration. Without we are not able to use the orb, which I really would like to do.
The text was updated successfully, but these errors were encountered: