move get_uid_trades function to orderbook api

it is used in two tests and only depends on the orderbook api at the moment.

Author: fhenneke

src/apis/orderbookapi.py

@@ -110,6 +110,18 @@ def get_trade(
         )
         return Trade(data, execution)
 
+    def get_uid_trades(self, solution: dict[str, Any]) -> dict[str, Trade] | None:
+        """Get a dictionary mapping UIDs to trades in a solution."""
+        trades_dict: dict[str, Trade] = {}
+        for execution in solution["orders"]:
+            uid = execution["id"]
+            order_data = self.get_order_data(uid)
+            if order_data is None:
+                return None
+            trades_dict[uid] = self.get_trade(order_data, execution)
+
+        return trades_dict
+
     def get_quote(self, trade: Trade) -> Optional[Trade]:
         """
         Given a trade, compute buy_amount, sell_amount, and fee_amount of the trade

src/monitoring_tests/solver_competition_surplus_test.py

@@ -30,7 +30,7 @@ def compare_orders_surplus(self, competition_data: dict[str, Any]) -> bool:
 
         solution = competition_data["solutions"][-1]
 
-        trades_dict = self.get_uid_trades(solution)
+        trades_dict = self.orderbook_api.get_uid_trades(solution)
         if trades_dict is None:
             return False
 
@@ -98,18 +98,6 @@ def get_trade_alternatives(
 
         return trade_alt_list
 
-    def get_uid_trades(self, solution: dict[str, Any]) -> dict[str, Trade] | None:
-        """Get a dictionary mapping UIDs to trades in a solution."""
-        trades_dict: dict[str, Trade] = {}
-        for execution in solution["orders"]:
-            uid = execution["id"]
-            order_data = self.orderbook_api.get_order_data(uid)
-            if order_data is None:
-                return None
-            trades_dict[uid] = self.orderbook_api.get_trade(order_data, execution)
-
-        return trades_dict
-
     def get_uid_order_execution(
         self, solution: dict[str, Any]
     ) -> dict[str, OrderExecution]: