Skip to content

Commit 473abde

Browse files
authored
Increase thresholds for cost coverage test for zero-signed fee orders (#96)
This PR attempts to reduce the very noisy errors of the cost coverage test.
1 parent d7ee532 commit 473abde

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/monitoring_tests/cost_coverage_zero_signed_fee.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ def cost_coverage(self, competition_data: dict[str, Any], gas_cost: float) -> bo
6464
)
6565
total_fee += fee
6666
if total_fee - gas_cost > 0.002 or total_fee - gas_cost < -0.002:
67-
if zero_signed_fee_market:
67+
if zero_signed_fee_market and (
68+
total_fee - gas_cost > 0.02 or total_fee - gas_cost < -0.01
69+
):
6870
self.alert(
6971
f'"Fees - gasCost" is {total_fee - gas_cost} \
7072
for {competition_data["transactionHash"]}.'

0 commit comments

Comments
 (0)