From 97d0d8f685bdca8aa33a5de1bf832b309d9302e8 Mon Sep 17 00:00:00 2001 From: Felix Henneke Date: Thu, 20 Jun 2024 12:36:40 +0200 Subject: [PATCH] Increase threshold for combinatorial auction test (#111) At the moment, the combinatorial auction test generates non-actionable alerts. The original threshold of `0.001 ETH` is not large enough to avoid false positives due to, e.g., inaccurate fee estimates. The new threshold of `0.005 ETH` is more in line with other thresholds used. Midterm we could also remove the test or redesign it to have less overlap with the competition surplus test. --- src/constants.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/constants.py b/src/constants.py index 0b656da..07e1dd9 100644 --- a/src/constants.py +++ b/src/constants.py @@ -10,7 +10,7 @@ SURPLUS_REL_DEVIATION = 0.004 # combinatorial auctions -COMBINATORIAL_AUCTION_ABSOLUTE_DEVIATION_ETH = 0.001 +COMBINATORIAL_AUCTION_ABSOLUTE_DEVIATION_ETH = 0.005 # cost coverage test COST_COVERAGE_ABSOLUTE_DEVIATION_ETH = 0.01