Fix scaling of objective in combinatorial auction test (#87)

fhenneke · web-flow · commit f02246f2654c · 2023-11-13T16:19:31.000+01:00
diff --git a/src/monitoring_tests/combinatorial_auction_surplus_test.py b/src/monitoring_tests/combinatorial_auction_surplus_test.py
@@ -163,7 +163,8 @@ def get_token_pairs_surplus(
         if len(surplus_dict) == 1:
             for token_pair in surplus_dict:
                 surplus_dict[token_pair] = min(
-                    surplus_dict[token_pair], solution["objective"]["total"]
+                    surplus_dict[token_pair],
+                    Fraction(solution["objective"]["total"]) / 10**18,
                 )
 
         return surplus_dict
diff --git a/tests/e2e/combinatorial_auction_surplus_test.py b/tests/e2e/combinatorial_auction_surplus_test.py
@@ -25,7 +25,9 @@ def test_surplus(self) -> None:
         # tx_hash = "0xe28b92ba73632d6b167fdb9bbfec10744ce208536901dd43379a6778c4408536"
         # tx_hash = "0xad0ede9fd68481b8ef4722d069598898e01d61427ccb378ca4c82c772c6644e0"
         # tx_hash = "0xead8f01e8e24fdc306fca8fcac5146edc22c27e49a7aad6134adc2ad50ba8581"
-        tx_hash = "0x6200e744e5d6f9990271be53840c01044cc19f3a8526190e1eaac0bc5fefed85"
+        # tx_hash = "0x6200e744e5d6f9990271be53840c01044cc19f3a8526190e1eaac0bc5fefed85"
+        # uncovered bug with wrong scaling of objective
+        tx_hash = "0x97b2f8402d239e16b62b7cc2302ed77ac8fa40d63114ab6804041c9d3b9e6b81"
         self.assertTrue(surplus_test.run(tx_hash))
 
 

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,8 @@ def get_token_pairs_surplus(`
`163`	`163`	`if len(surplus_dict) == 1:`
`164`	`164`	`for token_pair in surplus_dict:`
`165`	`165`	`surplus_dict[token_pair] = min(`
`166`		`- surplus_dict[token_pair], solution["objective"]["total"]`
	`166`	`+ surplus_dict[token_pair],`
	`167`	`+ Fraction(solution["objective"]["total"]) / 10**18,`
`167`	`168`	`)`
`168`	`169`
`169`	`170`	`return surplus_dict`