Add test for CoW AMM commitment #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the test fails if a commitment different from the default commitment is set
harisang
reviewed
May 22, 2024
harisang
reviewed
May 22, 2024
harisang
reviewed
May 23, 2024
|
Looks good overall. It's hard to be very confident this works but we can merge and see I guess... Will wait for you to fix the comments before approving. |
|
I fixed to doc strings. If you approve I would merge and see how it goes. |
harisang
approved these changes
May 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With enabling phase 2 of CoW AMM, solvers can execute CoW AMM orders with custom amounts. This requires commiting and uncommiting the order in the CoW AMM smart contract. Not uncommiting the order is a violation of social consensus rules since it prevents the default order from getting executed.
This PR implements a test where after every settlement which contains a precommit interaction from the CoW AMM address the commited order for that address is checked.
Since there seem to be no commits so far, the code is a bit difficult to test. I added a test with tailored call data.