Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with central server #32

Conversation

codersharma2001
Copy link

Created the Integration between the Central Server and CoW Template Server

Copy link

github-actions bot commented May 8, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@fhenneke fhenneke mentioned this pull request May 8, 2024
@fhenneke
Copy link
Contributor

fhenneke commented May 8, 2024

Hey @codersharma2001,
thanks for taking your time to create a pull request!

I have difficulties in understanding the goal and the code changes of this PR.

  • Could you please elaborate on what you are trying to achieve with the code in this PR? Is it about implementing a simple solver which checks prices at some external venue? Is it supposed to be general functionality for a template solver or an example of a specific solver?
  • There are references to http://localhost:3000/bestRates, but no way for me to check what it does. To test the code I need to be able to run it on my machine.
  • This PR changes every file in the repository. Is this due to some misconfiguration with regards to line endings? Please have a look here.

@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants