Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on WrappedCheckedException validation before calling super #9

Merged

Conversation

bkoprucu
Copy link
Contributor

@bkoprucu bkoprucu commented Oct 5, 2024

No description provided.

Copy link
Owner

@cowwoc cowwoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I only saw the PR now.

@cowwoc
Copy link
Owner

cowwoc commented Oct 30, 2024

@bkoprucu Can you please re-base your PR? We need to fix the CLA Assistant prior to merging.

@cowwoc cowwoc force-pushed the master branch 18 times, most recently from 3f90049 to 1dfc1ce Compare October 31, 2024 21:24
@bkoprucu bkoprucu changed the title Fail on WrappedCheckedException validation before creating super Fail on WrappedCheckedException validation before calling super Dec 8, 2024
@bkoprucu bkoprucu force-pushed the fail-on-null-check-before-creating-super branch from 48f04dd to 90b51c8 Compare December 8, 2024 16:36
@bkoprucu
Copy link
Contributor Author

bkoprucu commented Dec 8, 2024

@bkoprucu Can you please re-base your PR? We need to fix the CLA Assistant prior to merging.

I did. I guess the build pipeline needs to be fixed. Maybe permissions are missing for contribution.

@cowwoc
Copy link
Owner

cowwoc commented Dec 8, 2024

  1. I renamed the default branch from master to main so you're going to have to run:
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a
  1. I pushed a permission fix for the CLA workflow so I plan to retry it now.

@cowwoc
Copy link
Owner

cowwoc commented Dec 8, 2024

It doesn't look like GitHub is willing to pick up the changes to the CLA workflow unless you rebase your PR.

You could either rebase and we'll try again, or I can just commit these changes under my name. Sorry for the hassle. I'll get this working eventually :)

Let me know how you want to proceed.

@bkoprucu bkoprucu force-pushed the fail-on-null-check-before-creating-super branch from 90b51c8 to 51098cf Compare December 10, 2024 21:36
Copy link
Contributor

github-actions bot commented Dec 10, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@bkoprucu
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bkoprucu
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Dec 10, 2024
@bkoprucu bkoprucu requested a review from cowwoc December 12, 2024 16:01
@bkoprucu
Copy link
Contributor Author

  1. I renamed the default branch from master to main so you're going to have to run:
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a
2. I pushed a permission fix for the CLA workflow so I plan to retry it now.

This and commenting with "I have read the CLA Document and I hereby sign the CLA" made it work.
Thanks.

@cowwoc cowwoc merged commit 98f7437 into cowwoc:main Dec 12, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@cowwoc
Copy link
Owner

cowwoc commented Dec 12, 2024

Released in version 5.2. Thanks again!

@cowwoc cowwoc added this to the version-5.2 milestone Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants