From fb3c1a0cc6af6e80ea6c96152a95adcd71a3836f Mon Sep 17 00:00:00 2001 From: AlexisG Date: Fri, 17 May 2024 16:41:41 +0200 Subject: [PATCH] fix(models/document): Rename "stranger" locale This term had been replaced in the MyPapers app but was forgotten here. As a result, we've lost the ''(Foreign)'' display on papers such as the foreign driver's license, and this generates a lot of error logs. --- .../src/models/document/locales/en.json | 2 +- .../src/models/document/locales/fr.json | 2 +- .../src/models/document/locales/index.js | 4 ++-- .../src/models/document/locales/index.spec.js | 20 +++++++++---------- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/cozy-client/src/models/document/locales/en.json b/packages/cozy-client/src/models/document/locales/en.json index 8de0d3525..c215ff8e8 100644 --- a/packages/cozy-client/src/models/document/locales/en.json +++ b/packages/cozy-client/src/models/document/locales/en.json @@ -1,6 +1,6 @@ { "country": { - "stranger": "Stranger" + "foreign": "Foreign" }, "Scan": { "scan_a_doc": "Scan a doc", diff --git a/packages/cozy-client/src/models/document/locales/fr.json b/packages/cozy-client/src/models/document/locales/fr.json index 9a950509d..927c1f741 100644 --- a/packages/cozy-client/src/models/document/locales/fr.json +++ b/packages/cozy-client/src/models/document/locales/fr.json @@ -1,6 +1,6 @@ { "country": { - "stranger": "Étranger" + "foreign": "Étranger" }, "Scan": { "scan_a_doc": "Numériser un doc", diff --git a/packages/cozy-client/src/models/document/locales/index.js b/packages/cozy-client/src/models/document/locales/index.js index 23ad23430..6b9502a8d 100644 --- a/packages/cozy-client/src/models/document/locales/index.js +++ b/packages/cozy-client/src/models/document/locales/index.js @@ -29,8 +29,8 @@ const getBoundT = lang => { const country = opts?.country const emojiCountry = - country !== 'stranger' ? getEmojiByCountry(country) : null - const strangerLabel = country === 'stranger' ? t('country.stranger') : null + country !== 'foreign' ? getEmojiByCountry(country) : null + const strangerLabel = country === 'foreign' ? t('country.foreign') : null return emojiCountry || strangerLabel ? `${t(label, newOpts)} ${emojiCountry || strangerLabel}` diff --git a/packages/cozy-client/src/models/document/locales/index.spec.js b/packages/cozy-client/src/models/document/locales/index.spec.js index 0605efba3..8e2628092 100644 --- a/packages/cozy-client/src/models/document/locales/index.spec.js +++ b/packages/cozy-client/src/models/document/locales/index.spec.js @@ -20,16 +20,16 @@ describe('getBoundT', () => { }) it.each` - translationKey | country | smart_count | lang | expected - ${'Scan.items.national_id_card'} | ${undefined} | ${undefined} | ${'en'} | ${'ID card'} - ${'Scan.items.national_id_card'} | ${'fr'} | ${undefined} | ${'en'} | ${'ID card 🇫🇷'} - ${'Scan.items.national_id_card'} | ${'stranger'} | ${undefined} | ${'en'} | ${'ID card Stranger'} - ${'Scan.items.national_id_card'} | ${'be'} | ${1} | ${'en'} | ${'ID card 🇧🇪'} - ${'Scan.items.national_id_card'} | ${'be'} | ${2} | ${'en'} | ${'ID cards 🇧🇪'} - ${'Scan.items.national_id_card'} | ${'fr'} | ${1} | ${'en'} | ${'ID card 🇫🇷'} - ${'Scan.items.national_id_card'} | ${'fr'} | ${2} | ${'en'} | ${'ID cards 🇫🇷'} - ${'Scan.items.national_id_card'} | ${undefined} | ${1} | ${'en'} | ${'ID card'} - ${'Scan.items.national_id_card'} | ${undefined} | ${2} | ${'en'} | ${'ID cards'} + translationKey | country | smart_count | lang | expected + ${'Scan.items.national_id_card'} | ${undefined} | ${undefined} | ${'en'} | ${'ID card'} + ${'Scan.items.national_id_card'} | ${'fr'} | ${undefined} | ${'en'} | ${'ID card 🇫🇷'} + ${'Scan.items.national_id_card'} | ${'foreign'} | ${undefined} | ${'en'} | ${'ID card Foreign'} + ${'Scan.items.national_id_card'} | ${'be'} | ${1} | ${'en'} | ${'ID card 🇧🇪'} + ${'Scan.items.national_id_card'} | ${'be'} | ${2} | ${'en'} | ${'ID cards 🇧🇪'} + ${'Scan.items.national_id_card'} | ${'fr'} | ${1} | ${'en'} | ${'ID card 🇫🇷'} + ${'Scan.items.national_id_card'} | ${'fr'} | ${2} | ${'en'} | ${'ID cards 🇫🇷'} + ${'Scan.items.national_id_card'} | ${undefined} | ${1} | ${'en'} | ${'ID card'} + ${'Scan.items.national_id_card'} | ${undefined} | ${2} | ${'en'} | ${'ID cards'} `( 'should test if the translation is suitable with the param country: $country and with the param smart_count: $smart_count', ({ translationKey, country, smart_count, lang, expected }) => {