Skip to content

Improve translations for geolocation #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Improve translations for geolocation #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c14929
feat: Translate Android native permission popup for geolocation tracking
zatteo Nov 8, 2023
23405d8
feat: Translate Android persistent notification for geolocation track…
zatteo Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/app/domain/geolocation/tracking/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
clearAllData,
getFlagFailUpload
} from '/app/domain/geolocation/tracking/storage'
import { t } from '/locales/i18n'

export { Log, getAllLogs, sendLogFile } from '/app/domain/geolocation/helpers'
export { getOrCreateId, updateId } from '/app/domain/geolocation/tracking/user'
Expand Down Expand Up @@ -62,8 +63,14 @@ export const startTracking = async () => {
enableHeadless: true,
foregroundService: true,
backgroundPermissionRationale: {
message:
'Mémoriser vos déplacements nécessite de ≪ {backgroundPermissionOptionLabel} ≫'
message: t(
'services.geolocationTracking.androidBackgroundPermissionMessage'
)
},
notification: {
title: t('services.geolocationTracking.androidNotificationTitle'),
text: t('services.geolocationTracking.androidNotificationDescription'),
smallIcon: 'mipmap/ic_stat_ic_notification'
}
})
await BackgroundGeolocation.start()
Expand Down
5 changes: 5 additions & 0 deletions src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@
"onProgressMessage": "A file is being uploaded"
}
},
"geolocationTracking": {
"androidBackgroundPermissionMessage": "Recording your movements requires to ≪ {backgroundPermissionOptionLabel} ≫",
"androidNotificationTitle": "Location service on",
"androidNotificationDescription": "Your journey will be recorded into your Cozy"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ES version?

Also this mention "Cozy", so I suppose we should get an alternative text in extra-language files

},
"osReceive": {
"documentType": "Document Type:",
"submit": "Next",
Expand Down
5 changes: 5 additions & 0 deletions src/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@
"onProgressMessage": "Se está subiendo un archivo"
}
},
"geolocationTracking": {
"androidBackgroundPermissionMessage": "Registrar sus movimientos requiere ≪ {backgroundPermissionOptionLabel} ≫",
"androidNotificationTitle": "Servicio de localización en",
"androidNotificationDescription": "Tu viaje quedará registrado en tu Cozy"
},
"osReceive": {
"documentType": "Tipo de documento :",
"submit": "Siguiente",
Expand Down
5 changes: 5 additions & 0 deletions src/locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@
"onProgressMessage": "Un fichier est en cours d'envoi"
}
},
"geolocationTracking": {
"androidBackgroundPermissionMessage": "Mémoriser vos déplacements nécessite de ≪ {backgroundPermissionOptionLabel} ≫",
"androidNotificationTitle": "Service de localisation actif",
"androidNotificationDescription": "Votre déplacement sera enregistré dans votre Cozy"
},
"osReceive": {
"documentType": "Type de document :",
"submit": "Suivant",
Expand Down
3 changes: 3 additions & 0 deletions white_label/brands/cozy/js/locales/extra-en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
}
},
"services": {
"geolocationTracking": {
"androidNotificationDescription": "Your journey will be recorded into your Cozy"
},
"osReceive": {
"disableReasons": {
"multipleFiles": "{{appname}} does not allow you to import multiple files simultaneously. Please import your files one by one or use the {{appname}} application directly in your Cozy."
Expand Down
3 changes: 3 additions & 0 deletions white_label/brands/cozy/js/locales/extra-es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
}
},
"services": {
"geolocationTracking": {
"androidNotificationDescription": "Tu viaje quedará registrado en tu Cozy"
},
"osReceive": {
"disableReasons": {
"multipleFiles": "{{appname}} no permite importar varios archivos simultáneamente. Por favor, importa tus archivos uno a uno o utiliza la aplicación {{appname}} directamente en tu Cozy."
Expand Down
3 changes: 3 additions & 0 deletions white_label/brands/cozy/js/locales/extra-fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
}
},
"services": {
"geolocationTracking": {
"androidNotificationDescription": "Votre déplacement sera enregistré dans votre Cozy"
},
"osReceive": {
"disableReasons": {
"multipleFiles": "{{appname}} ne permet pas d'importer plusieurs fichiers simultanément. Merci d'importer vos fichier un par un ou utiliser directement l'application {{appname}} dans votre Cozy."
Expand Down
3 changes: 3 additions & 0 deletions white_label/brands/mabulle/js/locales/extra-en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
}
},
"services": {
"geolocationTracking": {
"androidNotificationDescription": "Your journey will be recorded into your personal space"
},
"osReceive": {
"disableReasons": {
"multipleFiles": "{{appname}} does not allow you to import multiple files simultaneously. Please import your files one by one or use the {{appname}} application directly in your personnal space."
Expand Down
3 changes: 3 additions & 0 deletions white_label/brands/mabulle/js/locales/extra-es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
}
},
"services": {
"geolocationTracking": {
"androidNotificationDescription": "Tu viaje quedará registrado en tu cuenta"
},
"osReceive": {
"disableReasons": {
"multipleFiles": "{{appname}} no permite importar varios archivos simultáneamente. Por favor, importa tus archivos uno a uno o utiliza la aplicación {{appname}} directamente en tu cuenta."
Expand Down
3 changes: 3 additions & 0 deletions white_label/brands/mabulle/js/locales/extra-fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
}
},
"services": {
"geolocationTracking": {
"androidNotificationDescription": "Votre déplacement sera enregistré dans votre espace personnel"
},
"osReceive": {
"disableReasons": {
"multipleFiles": "{{appname}} ne permet pas d'importer plusieurs fichiers simultanément. Merci d'importer vos fichier un par un ou utiliser directement l'application {{appname}} dans votre espace personnel."
Expand Down