From e1349623419d6805875946c2a250e76eb04dea72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20Poizat?= Date: Mon, 13 May 2024 16:03:18 +0200 Subject: [PATCH] fix: Display again contacts in in page menu Following previous fix that avoid _testHash to crash (99ae740), contacts were not displayed because we consider them as identities, so we never removed the "hidden" class. Let's remove it if identities "hidden" class is removed. --- apps/browser/src/inPageMenu/menu.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/browser/src/inPageMenu/menu.js b/apps/browser/src/inPageMenu/menu.js index f6bca50b270..f28cee15a5f 100755 --- a/apps/browser/src/inPageMenu/menu.js +++ b/apps/browser/src/inPageMenu/menu.js @@ -482,7 +482,9 @@ function _testHash() { if (oldFieldData && oldFieldData[key] === hash[key]) { continue; } - if (hash[key]) { + // At this point, a contact is considered as an identity so we need to remove the hidden class + // for existing type and also for contact if identity exists + if (hash[key] || (key === "contact" && hash["identity"])) { titleEl.textContent = options.title; options.updateFn(); rowsEl.classList.remove("hidden");