Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntentIFrame should not depend on cozy-client/withClient #2082

Open
trollepierre opened this issue Mar 28, 2022 · 1 comment
Open

IntentIFrame should not depend on cozy-client/withClient #2082

trollepierre opened this issue Mar 28, 2022 · 1 comment

Comments

@trollepierre
Copy link
Contributor

A Cozy-UI component should not know cozy-client.

We need to consume IntentIframe and provide a client in that case.

https://github.com/cozy/cozy-ui/blob/master/react/IntentIframe/IntentIframe.jsx#L105=

@Crash--
Copy link
Contributor

Crash-- commented Mar 28, 2022

A Cozy-UI component should not know cozy-client.

Strongly disagree on that point. We've a lot of components requiring cozy-client and I think it's a good way to do what we want to do.

On the other hand, having to split cozy-ui in two, with on one side "atomic components" (and thus not depending on client) and on the other side very high level components and thus potentially depending on Client, then yes I agree to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants