Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding Window #4787

Closed
freakin23 opened this issue Sep 16, 2024 · 5 comments · Fixed by #4792
Closed

Sliding Window #4787

freakin23 opened this issue Sep 16, 2024 · 5 comments · Fixed by #4792

Comments

@freakin23
Copy link
Contributor

freakin23 commented Sep 16, 2024

In the sliding window module under the subtopic "Sliding Window Minimum", instead of using the sliding window maximum question as a focus problem which was already used above why not use this question from CSES (Question link: https://cses.fi/boi24/task/3221). I think it would be much better for the module.

@bqi343
Copy link
Member

bqi343 commented Sep 16, 2024

aren't the problems the same?

can replace Leetcode with CSES since the latter source is preferred, but doesn't matter much

@freakin23
Copy link
Contributor Author

aren't the problems the same?

can replace Leetcode with CSES since the latter source is preferred, but doesn't matter much

I was just wondering if the subtopic is about "minimum" then why now include a problem related to that instead of "maximum"

@freakin23
Copy link
Contributor Author

or maybe I should include it in the problems section.

@bqi343
Copy link
Member

bqi343 commented Sep 16, 2024

oh, the subtopic name should be fixed.

anyway, if you want, you can replace the existing problem with the one you suggested (and rewrite the sols accordingly). no point in including both problems

@freakin23 freakin23 mentioned this issue Sep 20, 2024
4 tasks
@SansPapyrus683 SansPapyrus683 linked a pull request Sep 20, 2024 that will close this issue
4 tasks
@TheGamingMousse
Copy link
Contributor

maybe sliding window RMQ would be a more suitable name? because RMQ = max or min :trust:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants