Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fenwick Tree Updates #4803

Merged
merged 11 commits into from
Oct 5, 2024
Merged

Fenwick Tree Updates #4803

merged 11 commits into from
Oct 5, 2024

Conversation

TheGamingMousse
Copy link
Contributor

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.

  • I have added my solution according to the steps here.

  • I have followed the code conventions mentioned here.

    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

  • added a (in my opinion) cleaner 2d bit impl (which is also more in line w/ the PURS bit impl)

  • added a slightly different verison of the offline bit impl

    • like the bit impl in the purs module, everything is zero indexed here
    • greatly improved the efficiency of the code by passing in the vector for the ind function as a reference

Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my goat...

content/5_Plat/2DRQ.mdx Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
TheGamingMousse and others added 2 commits September 28, 2024 11:05
Co-authored-by: Kevin Sheng <55369003+SansPapyrus683@users.noreply.github.com>
Co-authored-by: Kevin Sheng <55369003+SansPapyrus683@users.noreply.github.com>
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Outdated Show resolved Hide resolved
TheGamingMousse and others added 2 commits September 28, 2024 11:28
Co-authored-by: Kevin Sheng <55369003+SansPapyrus683@users.noreply.github.com>
Co-authored-by: Kevin Sheng <55369003+SansPapyrus683@users.noreply.github.com>
content/5_Plat/2DRQ.mdx Show resolved Hide resolved
content/5_Plat/2DRQ.mdx Show resolved Hide resolved
@ryanchou-dev ryanchou-dev merged commit c4e9697 into master Oct 5, 2024
4 checks passed
@ryanchou-dev ryanchou-dev deleted the 2DRQ-Fenwick-Tree-Updates branch October 5, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants