Return state when the user provides a span

mborland · mborland · commit 0ec58429bdc9 · 2025-01-08T11:56:36.000-05:00
diff --git a/include/boost/crypt2/hash/detail/sha_1_2_hasher_base.hpp b/include/boost/crypt2/hash/detail/sha_1_2_hasher_base.hpp
@@ -35,7 +35,7 @@ class sha_1_2_hasher_base
 
     BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto update(compat::span<const compat::byte> data) noexcept -> state;
 
-    BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest_impl(compat::span<compat::byte, digest_size> data);
+    BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest_impl(compat::span<compat::byte, digest_size> data) -> state;
 
 public:
 
@@ -52,7 +52,7 @@ class sha_1_2_hasher_base
     BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto finalize() noexcept -> state;
 
     [[nodiscard("Digest is the function return value")]] BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest() noexcept -> return_type;
-    BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest(compat::span<compat::byte, digest_size> data) noexcept -> void;
+    BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest(compat::span<compat::byte, digest_size> data) noexcept -> state;
 
     template <typename Range>
     BOOST_CRYPT_GPU_ENABLED auto get_digest(Range&& data) noexcept -> void
@@ -96,11 +96,11 @@ auto sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest(Range&
 }
 
 template <compat::size_t digest_size, compat::size_t intermediate_hash_size>
-BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest_impl(compat::span<compat::byte, digest_size> data)
+BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest_impl(compat::span<compat::byte, digest_size> data) -> state
 {
     if (corrupted_)
     {
-        return data;
+        return state::state_error;
     }
     if (!computed_)
     {
@@ -112,14 +112,14 @@ BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto sha_1_2_hasher_base<digest_size, intermed
         data[i] = static_cast<compat::byte>(intermediate_hash_[i >> 2U] >> 8U * (3U - (i & 0x03U)));
     }
 
-    return data;
+    return state::success;
 }
 
 template <compat::size_t digest_size, compat::size_t intermediate_hash_size>
 BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto
-sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest(compat::span<compat::byte, digest_size> data) noexcept -> void
+sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest(compat::span<compat::byte, digest_size> data) noexcept -> state
 {
-    get_digest_impl(data);
+    return get_digest_impl(data);
 }
 
 template <compat::size_t digest_size, compat::size_t intermediate_hash_size>

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ class sha_1_2_hasher_base`
`35`	`35`
`36`	`36`	`BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto update(compat::span<const compat::byte> data) noexcept -> state;`
`37`	`37`
`38`		`- BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest_impl(compat::span<compat::byte, digest_size> data);`
	`38`	`+ BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest_impl(compat::span<compat::byte, digest_size> data) -> state;`
`39`	`39`
`40`	`40`	`public:`
`41`	`41`
`@@ -52,7 +52,7 @@ class sha_1_2_hasher_base`
`52`	`52`	`BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto finalize() noexcept -> state;`
`53`	`53`
`54`	`54`	`[[nodiscard("Digest is the function return value")]] BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest() noexcept -> return_type;`
`55`		`- BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest(compat::span<compat::byte, digest_size> data) noexcept -> void;`
	`55`	`+ BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto get_digest(compat::span<compat::byte, digest_size> data) noexcept -> state;`
`56`	`56`
`57`	`57`	`template <typename Range>`
`58`	`58`	`BOOST_CRYPT_GPU_ENABLED auto get_digest(Range&& data) noexcept -> void`
`@@ -96,11 +96,11 @@ auto sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest(Range&`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`template <compat::size_t digest_size, compat::size_t intermediate_hash_size>`
`99`		`-BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest_impl(compat::span<compat::byte, digest_size> data)`
	`99`	`+BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest_impl(compat::span<compat::byte, digest_size> data) -> state`
`100`	`100`	`{`
`101`	`101`	`if (corrupted_)`
`102`	`102`	`{`
`103`		`- return data;`
	`103`	`+ return state::state_error;`
`104`	`104`	`}`
`105`	`105`	`if (!computed_)`
`106`	`106`	`{`
`@@ -112,14 +112,14 @@ BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto sha_1_2_hasher_base<digest_size, intermed`
`112`	`112`	`data[i] = static_cast<compat::byte>(intermediate_hash_[i >> 2U] >> 8U * (3U - (i & 0x03U)));`
`113`	`113`	`}`
`114`	`114`
`115`		`- return data;`
	`115`	`+ return state::success;`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`template <compat::size_t digest_size, compat::size_t intermediate_hash_size>`
`119`	`119`	`BOOST_CRYPT_GPU_ENABLED_CONSTEXPR auto`
`120`		`-sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest(compat::span<compat::byte, digest_size> data) noexcept -> void`
	`120`	`+sha_1_2_hasher_base<digest_size, intermediate_hash_size>::get_digest(compat::span<compat::byte, digest_size> data) noexcept -> state`
`121`	`121`	`{`
`122`		`- get_digest_impl(data);`
	`122`	`+ return get_digest_impl(data);`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`template <compat::size_t digest_size, compat::size_t intermediate_hash_size>`