Fix #14488 (GUI: The Misra C checkbox in "Edit Project" dialog is unchecked) (danmar#8206)

Author: danmar

gui/manualtest/projectfiledialog.md

@@ -0,0 +1,18 @@
+
+# Project file dialog
+
+Some manual testing in the project file dialog interface
+
+
+## Test: Misra C checkbox
+
+Matrix: Use both open source and premium
+
+1. Load project file in trac ticket 14488
+1. Goto "Edit project"
+1. Goto "Addons" tab
+
+EXPECTED: The misra c checkbox should be checked
+
+TODO: can this test be automated
+

gui/projectfiledialog.cpp

@@ -414,8 +414,8 @@ void ProjectFileDialog::loadFromProjectFile(const ProjectFile *projectFile)
         mUI->mMisraC->setText("Misra C");
     else {
         mUI->mMisraC->setText("Misra C 2012  " + tr("Note: Open source Cppcheck does not fully implement Misra C 2012"));
-        updateAddonCheckBox(mUI->mMisraC, projectFile, dataDir, ADDON_MISRA);
     }
+    updateAddonCheckBox(mUI->mMisraC, projectFile, dataDir, ADDON_MISRA);
     mUI->mMisraVersion->setEnabled(mUI->mMisraC->isChecked());
     connect(mUI->mMisraC, &QCheckBox::toggled, mUI->mMisraVersion, &QComboBox::setEnabled);