Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape sequence for ? #7

Open
dpb587 opened this issue Mar 30, 2017 · 2 comments · May be fixed by #19
Open

Escape sequence for ? #7

dpb587 opened this issue Mar 30, 2017 · 2 comments · May be fixed by #19

Comments

@dpb587
Copy link

dpb587 commented Mar 30, 2017

go-patch introduces ? as a new, non-rfc6901 special character, but there's not an escape sequence defined. Preferences? Since non-standard, start in descending order; ~9?

rfc6901Decoder = strings.NewReplacer("~0", "~", "~1", "/")
rfc6901Encoder = strings.NewReplacer("~", "~0", "/", "~1")

@cppforlife
Copy link
Owner

@dpb587 dont have a pref. may be something high in the num range (99?)

@bgandon
Copy link

bgandon commented May 13, 2018

For completeness, I'd like to mention here this comment by Dmitriy that suggests the ~2 sequence for escaping ?.

@bgandon bgandon linked a pull request Apr 20, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants