Add test for issue xamarin#14350

Author: cpraehauso

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue14350.xaml

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
+             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+             xmlns:d="http://xamarin.com/schemas/2014/forms/design"
+             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+             mc:Ignorable="d"
+			 Title="Test 14350"
+             x:Class="Xamarin.Forms.Controls.Issues.Issue14350">
+
+    <RefreshView IsRefreshing="{Binding IsRefreshing}" Command="{Binding Refresh}" IsEnabled="{Binding IsRefreshAllowed}">
+        <ScrollView>
+            <StackLayout>
+                <Label Text="Test for issue #14350" />
+                <Label Text="Refreshing ..." IsVisible="{Binding IsRefreshing}" BackgroundColor="Orange"/>
+                <Label Text="Enable refresh:" IsVisible="{Binding IsRefreshAllowed}" TextColor="Green"/>
+                <StackLayout>
+                    <StackLayout Orientation="Horizontal">
+                        <Label Text="Refresh enabled:" HorizontalOptions="FillAndExpand"/>
+                        <Switch IsToggled="{Binding IsRefreshAllowed}" />
+                    </StackLayout>
+                </StackLayout>
+                <StackLayout>
+                    <Label Text="Test steps (Android):" />
+                    <Label Text="1. Swipe to refresh" />
+                    <Label Text="2. Refresh/busy indicator appears at the top" />
+                    <Label Text="3. Refresh/busy indicator should remain visible until content changes (refresh is finished).
+					   due to issue #14350 the indicator vanishes too early if Command.CanExecute toggles (in this test after 1 second)." />
+                    <Label Text="4. Repeat steps 1 to 3 multiple times" />
+                </StackLayout>
+            </StackLayout>
+        </ScrollView>
+    </RefreshView>
+</ContentPage>

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue14350.xaml.cs

@@ -0,0 +1,26 @@
+using System.ComponentModel;
+
+using Xamarin.Forms;
+using Xamarin.Forms.CustomAttributes;
+using Xamarin.Forms.Internals;
+
+namespace Xamarin.Forms.Controls.Issues
+{
+	// Learn more about making custom code visible in the Xamarin.Forms previewer
+	// by visiting https://aka.ms/xamarinforms-previewer
+	[DesignTimeVisible(false)]
+	[Preserve(AllMembers = true)]
+	[Issue(IssueTracker.Github, 14350,
+		"[Bug] RefreshView to completes instantly when using AsyncCommand or Command with CanExecute functionality",
+		PlatformAffected.Android)]
+	public partial class Issue14350 : ContentPage
+	{
+		public Issue14350()
+		{
+#if APP
+			InitializeComponent();
+			BindingContext = new ViewModelIssue8384();
+#endif
+		}
+	}
+}

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue8384.xaml.cs

@@ -55,6 +55,7 @@ public bool Allow
 
 		private List<string> _items;
 		private bool _isRefreshing;
+		private bool _isRefreshAllowed = true;
 		private MyCommand _refresh;
 
 		static readonly List<string> FIRST_LIST = new List<string>() {
@@ -78,6 +79,19 @@ public bool IsRefreshing
 			}
 		}
 
+		public bool IsRefreshAllowed
+		{
+			get
+			{
+				return _isRefreshAllowed;
+			}
+			set
+			{
+				_isRefreshAllowed = value;
+				OnPropertyChanged("IsRefreshAllowed");
+			}
+		}
+
 		public ViewModelIssue8384()
 		{
 			Items = FIRST_LIST;

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

@@ -1795,6 +1795,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)Issue11795.xaml.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Issue14528.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Issue14286.xaml.cs" />
+	<Compile Include="$(MSBuildThisFileDirectory)Issue14350.xaml.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Issue14613.xaml.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Issue13930.xaml.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Issue11211.xaml.cs" />
@@ -2282,6 +2283,9 @@
     </EmbeddedResource>
     <EmbeddedResource Include="$(MSBuildThisFileDirectory)Issue14286.xaml">
       <Generator>MSBuild:UpdateDesignTimeXaml</Generator>
+    </EmbeddedResource>
+	<EmbeddedResource Include="$(MSBuildThisFileDirectory)Issue14350.xaml">
+      <Generator>MSBuild:UpdateDesignTimeXaml</Generator>
     </EmbeddedResource>
     <EmbeddedResource Include="$(MSBuildThisFileDirectory)Issue14613.xaml">
       <Generator>MSBuild:UpdateDesignTimeXaml</Generator>