Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with linked brushing #24

Closed
aloboa opened this issue Sep 29, 2018 · 4 comments
Closed

Problem with linked brushing #24

aloboa opened this issue Sep 29, 2018 · 4 comments

Comments

@aloboa
Copy link

aloboa commented Sep 29, 2018

(not sure this is the right place for this comment. If this is not, I apologize).
I have a caveat with the example of section
"4.2.3 Linking with other htmlwidgets"
The example seems dependent upon
install_github("rstudio/leaflet#346")
otherwise, if I just install
install_github("rstudio/leaflet")
I get blue color for points on the right map when selecting on the left scatterplot (where points are red or
the selected color), which is inconvenient as selected points cannot be identified on the map.
As this type of linked brushing is very important for me, I would like to know if this code will be
valid for future standard releases of leaflet: sticking to #346 might not be possible in the future or interfere with newer improvements.
Thanks

@aloboa
Copy link
Author

aloboa commented Oct 1, 2018

Actually just found a problem with keeping #346: package tmap requires leaflet > 2.0.1.
namespace ‘leaflet’ 1.1.0.9000 is already loaded, but >= 2.0.1 is required

@cpsievert
Copy link
Owner

cpsievert commented Oct 1, 2018

Hopefully leaflet will officially add that functionality but you can also use plot_mapbox() -- https://blog.cpsievert.me/2018/03/30/visualizing-geo-spatial-data-with-sf-and-plotly/

@aloboa
Copy link
Author

aloboa commented Feb 14, 2019

Do not argue against closing this issue, but please note that book section "4.2.3 Linking with other htmlwidgets"
does not actually work.

@cpsievert
Copy link
Owner

The example works, you just can run that version of leaflet with tmap loaded...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants