Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The spec test ToDateTime4 does not translate properly #1298

Closed
EvanMachusak opened this issue Dec 5, 2023 · 1 comment · Fixed by #1313
Closed

The spec test ToDateTime4 does not translate properly #1298

EvanMachusak opened this issue Dec 5, 2023 · 1 comment · Fixed by #1313
Assignees
Labels

Comments

@EvanMachusak
Copy link

The expected output ToDateTime4 in CqlTypeOperatorsTest is defined to be:
@2014-01-01T12:05:05.955+01:30

The converted ELM for this expression does not include the offset minutes value and produces this instead:

{
          "type" : "DateTime",
          "year" : {
            "type" : "Literal",
            "valueType" : "{urn:hl7-org:elm-types:r1}Integer",
            "value" : "2014"
          },
          "month" : {
            "type" : "Literal",
            "valueType" : "{urn:hl7-org:elm-types:r1}Integer",
            "value" : "1"
          },
          "day" : {
            "type" : "Literal",
            "valueType" : "{urn:hl7-org:elm-types:r1}Integer",
            "value" : "1"
          },
          "hour" : {
            "type" : "Literal",
            "valueType" : "{urn:hl7-org:elm-types:r1}Integer",
            "value" : "12"
          },
          "minute" : {
            "type" : "Literal",
            "valueType" : "{urn:hl7-org:elm-types:r1}Integer",
            "value" : "5"
          },
          "second" : {
            "type" : "Literal",
            "valueType" : "{urn:hl7-org:elm-types:r1}Integer",
            "value" : "5"
          },
          "millisecond" : {
            "type" : "Literal",
            "valueType" : "{urn:hl7-org:elm-types:r1}Integer",
            "value" : "955"
          },
          "timezoneOffset" : {
            "type" : "Literal",
            "valueType" : "{urn:hl7-org:elm-types:r1}Decimal",
            "value" : "1.0"
          },
          "locator" : "89:2-89:31",
          "resultTypeName" : "{urn:hl7-org:elm-types:r1}DateTime"
        }

The timezoneOffset value is 1.0, not 1.5 as expected.

@JPercival
Copy link
Contributor

Fix pending review here: #1313

@JPercival JPercival self-assigned this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants