Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move headers so that project is submodule-friendly #62

Open
no-more-secrets opened this issue Apr 20, 2019 · 2 comments · May be fixed by #63
Open

Move headers so that project is submodule-friendly #62

no-more-secrets opened this issue Apr 20, 2019 · 2 comments · May be fixed by #63

Comments

@no-more-secrets
Copy link

I would like to send a PR that does the following:

  1. Move the headers from include/*.h into include/midifile/*.h
  2. Change code to include as e.g. #include "midifile/MidiEvent.h"
  3. Change CMakeLists.txt file to to use target_include_directories in accordance with modern CMake style.

This will make the project more modular and friendly when used as a submodule in a larger project and is in accordance with standard procedure. Do you have any issues with this? If not then let me know and I will send a pull request. Thanks
@no-more-secrets no-more-secrets linked a pull request Apr 22, 2019 that will close this issue
Open
@no-more-secrets
Copy link
Author

Oh and it would be great if we could merge this before any further commits are pushed to master because then there may be merge conflicts in the header files :-)

@no-more-secrets
Copy link
Author

Ping! Is this repo still being maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move header files into include/midifile folder. no-more-secrets/midifile
1 participant
@no-more-secrets