Admin/XMover: Implement suggestions by CodeRabbit

Author: amotl

CHANGES.md

@@ -1,8 +1,7 @@
 # Changelog
 
 ## Unreleased
-- Admin: Added XMover - CrateDB Shard Analyzer and Movement Tool.
-  Thanks, @WalBeh.
+- Admin: Added XMover - CrateDB shard analyzer and movement tool. Thanks, @WalBeh.
 
 ## 2025/08/19 v0.0.41
 - I/O: Updated to `influxio-0.6.0`. Thanks, @ZillKhan.

doc/admin/xmover/handbook.md

@@ -368,7 +368,7 @@ xmover recommend --prioritize-zones --execute
 
 ### Connection String Format
 
-```
+```text
 https://hostname:port
 ```
 
@@ -407,31 +407,31 @@ xmover analyze
 ### Common Issues and Solutions
 
 1. **Zone Conflicts**
-   ```
+   ```text
    Error: "NO(a copy of this shard is already allocated to this node)"
    ```
    - **Cause**: Target node already has a copy of the shard
    - **Solution**: Use `xmover zone-analysis --show-shards` to find alternative targets
    - **Prevention**: Always use `xmover validate-move` before executing moves
 
 2. **Zone Allocation Limits**
-   ```
+   ```text
    Error: "too many copies of the shard allocated to nodes with attribute [zone]"
    ```
    - **Cause**: CrateDB's zone awareness prevents too many copies in same zone
    - **Solution**: Move shard to a different availability zone
    - **Prevention**: Use `xmover recommend` which respects zone constraints
 
 3. **Insufficient Space**
-   ```
+   ```text
    Error: "not enough disk space"
    ```
    - **Cause**: Target node lacks sufficient free space
    - **Solution**: Choose node with more capacity or free up space
    - **Check**: `xmover analyze` to see available space per node
 
 4. **High Disk Usage Blocking Moves**
-   ```
+   ```text
    Error: "Target node disk usage too high (85.3%)"
    ```
    - **Cause**: Target node exceeds default 85% disk usage threshold
@@ -465,7 +465,7 @@ XMover uses configurable safety thresholds to prevent risky moves:
 xmover recommend --max-disk-usage 90 --prioritize-space
 
 # For urgent space relief
-xmover validate-move SCHEMA.TABLE SHARD_ID FROM TO --max-disk-usage 95
+xmover validate-move <SCHEMA.TABLE> <SHARD_ID> <FROM> <TO> --max-disk-usage 95
 ```
 
 **When to Adjust Thresholds:**

doc/admin/xmover/index.md

@@ -25,5 +25,5 @@ SQL commands for shard rebalancing and node decommissioning.
 
 Handbook <handbook>
 Troubleshooting <troubleshooting>
-Query gallery <queries>
+Query Gallery <queries>
 ```

doc/admin/xmover/queries.md

@@ -47,8 +47,15 @@ select node['name'], primary,  sum(size) / 1024^3, count(id)  from sys.shards  g
 ```
 
 ## Nodes available Space
-
 ```sql
+SELECT
+  name,
+  attributes['zone'] AS zone,
+  fs['total']['available'] / power(1024, 3) AS available_gb
+FROM sys.nodes
+ORDER BY name;
+```
+```text
 +------------+--------------------+-----------------------------------------------+
 | name       | attributes['zone'] | (fs[1]['disks']['available'] / 1.073741824E9) |
 +------------+--------------------+-----------------------------------------------+
@@ -87,8 +94,7 @@ SELECT 8 rows in set (0.062 sec)
 
 ## Move REROUTE
 ```sql
-
-alter table "curvo"."bottlefieldData" reroute move shard 21 from 'data-hot-2' to 'data-hot-3';
+ALTER TABLE curvo.bottlefielddata REROUTE MOVE SHARD 21 FROM 'data-hot-2' TO 'data-hot-3';
 ```
 ---
 

doc/admin/xmover/troubleshooting.md

@@ -232,7 +232,10 @@ CRATE_SSL_VERIFY=true
 **Step 3: Test Network Access**
 ```bash
 # Test HTTP connectivity
-curl -u username:password https://your-cluster:4200/_sql -d '{"stmt":"SELECT 1"}'
+curl -u 'username:password' \
+  -H 'Content-Type: application/json' \
+  'https://your-cluster:4200/_sql' \
+  -d '{"stmt":"SELECT 1"}'
 ```
 
 #### Prevention
@@ -285,7 +288,7 @@ xmover explain-error "your error message here"
 
 4. **Validate specific moves**
    ```bash
-   xmover validate-move SCHEMA.TABLE SHARD_ID FROM TO
+   xmover validate-move <SCHEMA.TABLE> <SHARD_ID> <FROM> <TO>
    ```
 
 5. **Execute gradually**