Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vfkit to brew #39

Closed
cfergeau opened this issue May 10, 2023 · 8 comments
Closed

Add vfkit to brew #39

cfergeau opened this issue May 10, 2023 · 8 comments
Assignees

Comments

@cfergeau
Copy link
Collaborator

More projects than just crc are using vfkit (podman, #38, ...). Having vfkit available in brew would make it a lot easier to install.
I made a formula as part of crc-org/crc#3476 , it's still available at https://github.com/cfergeau/homebrew-crc

This needs to be submitted upstream.

@cfergeau
Copy link
Collaborator Author

At the moment, vfkit can be installed with:

brew tap cfergeau/crc
brew install vfkit

@nirs
Copy link
Contributor

nirs commented Dec 13, 2024

At the moment, vfkit can be installed with:

brew tap cfergeau/crc
brew install vfkit

But it provides only 0.5.1. This breaks with my script:

Error: unknown option for usb-mass-storage devices: readonly

Can you add 0.6.0 to your brew tap?

@cfergeau
Copy link
Collaborator Author

Can you add 0.6.0 to your brew tap?

There was an open PR for this, it's now merged.

@nirs
Copy link
Contributor

nirs commented Jan 18, 2025

At the moment, vfkit can be installed with:

brew tap cfergeau/crc
brew install vfkit

This builds vfkit on the machine, which is very slow. For example in CI I need to rebuild vfkit for every run.

Can we change to install a built executable?

@nirs
Copy link
Contributor

nirs commented Jan 18, 2025

For now I'm installing vkfit from the github releases instead. Maybe this should be documented instead or in addition to brew?

tag="$(curl -fsSL https://api.github.com/repos/crc-org/vfkit/releases/latest | jq -r .tag_name)"
curl -LO https://github.com/crc-org/vfkit/releases/download/$tag/vfkit
sudo install vfkit /usr/local/bin/

@vyasgun
Copy link
Contributor

vyasgun commented Feb 12, 2025

/assign

@vyasgun vyasgun moved this to Work In Progress in Project planning: crc Feb 12, 2025
@cfergeau
Copy link
Collaborator Author

This needs to be submitted upstream.

By this, I mean having a vfkit.rb file in https://github.com/Homebrew/homebrew-core/tree/master/Formula/v

@cfergeau
Copy link
Collaborator Author

This is upstream now thanks to Gunjan https://github.com/Homebrew/homebrew-core/blob/master/Formula/v/vfkit.rb
Prebuilt bottles were added in Homebrew/homebrew-core@ff38c93

The podman formula still uses its own copy of vfkit https://github.com/Homebrew/homebrew-core/blob/85ced81711fc1d9d1df31492f2de06396020114d/Formula/p/podman.rb#L65-L70 but that's unrelated to this issue.

@github-project-automation github-project-automation bot moved this from Work In Progress to Done in Project planning: crc Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants