-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement and Style 404 Error Page with Vue Router Integration #532 #561
base: main
Are you sure you want to change the base?
Conversation
- Created ErrorPage component for 404 handling. - Configured Vue Router to redirect to ErrorPage for undefined routes. - Verified 404 error page layout and functionality.
✅ Deploy Preview for creativecommons-chooser ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@TimidRobot @Shafiya-Heena @possumbilities pls review this pr for issue [Feature] Style and Theme Error Pages #532 (#532) |
Co-authored-by: Olga Bulat <obulat@gmail.com>
@kris70lesgo Hi, and thanks for this! This PR would also need to build out its changes to |
margin-top: -50px; | ||
} | ||
</style> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing End of File
<h1 class="text-center">404</h1> | ||
</div> | ||
|
||
<div class="contant_box_404"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling error contant
should be content
} | ||
|
||
.four_zero_four_bg { | ||
background-image: url(https://cdn.dribbble.com/users/285475/screenshots/2083086/dribbble_1.gif); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would not want to pull in assets like this from a third-party. Please remove.
@kris70lesgo Thanks for this, can you please (while not losing all your descriptive content within the PR's content) re-add all the things you deleted from the PR template and fill it out fully (as relevant)? It is now missing pieces that need to be present to be merged. |
Fixes
Description
-Ensures error pages do not break the flow of the user by preventing navigation disruption as well as ensuring the application's consistency.
-It designs error pages to be as light as possible, thereby optimizing performance and reducing resource usage for faster load times.
-It develops a dedicated ErrorPage.vue component with a clean and minimal aesthetic, styled and themed to fit into the overall design without being too heavy.
-Proper routing is set up through Vue Router to correctly catch 404s, meaning implementation does not use Legacy (Vue) Vocabulary components.
Technical details
The ErrorPage.vue component was built to show a styled 404 error page using semantic HTML and scoped CSS for a minimal and responsive design. The Vue Router was set up in index.js to forward all unmatched routes (*) to this component so that any invalid URLs were handled seamlessly. The lightweight layout of the error page keeps design consistency and loads fast, with a temporary external background image that could be replaced with a local asset later for more reliability.
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin