diff --git a/apps/front/modules/default/actions/breadcrumbComponent.class.php b/apps/front/modules/default/actions/breadcrumbComponent.class.php index b24c21b..6832e03 100644 --- a/apps/front/modules/default/actions/breadcrumbComponent.class.php +++ b/apps/front/modules/default/actions/breadcrumbComponent.class.php @@ -31,7 +31,6 @@ public function execute($request) $fileBreadCrumbList = FileQuery::create() ->filterById($fileId, Criteria::NOT_EQUAL) ->filterByBranchId($this->currentBreadCrumbFile->getBranchId()) - ->filterByIsBinary(false) ->orderByFilename() ->find() ; diff --git a/apps/front/modules/default/actions/fileAction.class.php b/apps/front/modules/default/actions/fileAction.class.php index 07034ac..9c34593 100644 --- a/apps/front/modules/default/actions/fileAction.class.php +++ b/apps/front/modules/default/actions/fileAction.class.php @@ -35,7 +35,6 @@ public function execute($request) ->select(array('Id', 'Filename')) ->filterByBranchId($this->file->getBranchId()) ->filterByFilename($this->file->getFilename(), Criteria::LESS_THAN) - ->filterByIsBinary(false) ->orderByFilename(Criteria::DESC) ->find() ; @@ -44,12 +43,10 @@ public function execute($request) ->select(array('Id', 'Filename')) ->filterByBranchId($this->file->getBranchId()) ->filterByFilename($this->file->getFilename(), Criteria::GREATER_THAN) - ->filterByIsBinary(false) ->orderByFilename(Criteria::ASC) ->find() ; - $commitFrom = $request->getParameter('from', $this->branch->getCommitReference()); $commitTo = $request->getParameter('to', $this->branch->getLastCommit()); $this->commit_from = null; @@ -77,28 +74,53 @@ public function execute($request) $this->previousFileId = $this->findClosestFileId($previousFiles, $modifiedFiles); $this->nextFileId = $this->findClosestFileId($nextFiles, $modifiedFiles); - $this->fileContentLines = $this->gitCommand->getShowFileFromBranch( - $this->repository->getGitDir(), - $commitFrom, - $commitTo, - $this->file->getFilename(), - $options - ); + if ($this->file->getIsBinary()) + { + $oldBinaryContent = $this->gitCommand->getShowFile( + $this->repository->getGitDir(), + $commitFrom, + $this->file->getFilename() + ); - $fileLineCommentsModel = CommentQuery::create() - ->filterByFileId($this->file->getId()) - ->filterByCommit($this->file->getLastChangeCommit()) - ->filterByType(CommentPeer::TYPE_LINE) - ->find() - ; + $this->oldImageExists = !(strpos($oldBinaryContent, 'fatal: Path') === 0); + $this->oldImageType = ImageUtils::getImageTypeFromContent($oldBinaryContent); + $this->oldImageContent = base64_encode($oldBinaryContent); - $this->userId = $this->getUser()->getId(); + $newBinaryContent = $this->gitCommand->getShowFile( + $this->repository->getGitDir(), + $commitTo, + $this->file->getFilename() + ); - $this->fileLineComments = array(); - foreach ($fileLineCommentsModel as $fileLineCommentModel) + $this->newImageExists = !(strpos($newBinaryContent, 'fatal: Path') === 0); + $this->newImageType = ImageUtils::getImageTypeFromContent($newBinaryContent); + $this->newImageContent = base64_encode($newBinaryContent); + } + else { - $this->fileLineComments[$fileLineCommentModel->getPosition()][] = $fileLineCommentModel; + $this->fileContentLines = $this->gitCommand->getShowFileFromBranch( + $this->repository->getGitDir(), + $commitFrom, + $commitTo, + $this->file->getFilename(), + $options + ); + + $fileLineCommentsModel = CommentQuery::create() + ->filterByFileId($this->file->getId()) + ->filterByCommit($this->file->getLastChangeCommit()) + ->filterByType(CommentPeer::TYPE_LINE) + ->find() + ; + + $this->fileLineComments = array(); + foreach ($fileLineCommentsModel as $fileLineCommentModel) + { + $this->fileLineComments[$fileLineCommentModel->getPosition()][] = $fileLineCommentModel; + } } + + $this->userId = $this->getUser()->getId(); } /** diff --git a/apps/front/modules/default/templates/fileListSuccess.php b/apps/front/modules/default/templates/fileListSuccess.php index aae2efe..9db6836 100644 --- a/apps/front/modules/default/templates/fileListSuccess.php +++ b/apps/front/modules/default/templates/fileListSuccess.php @@ -47,15 +47,14 @@